Update the fully mounted check in JVMTI Suspend/Resume Thread #18448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fengxue-IS Requesting your review. fyi @tajila |
|
jenkins test sanity alinux64 jdk21 |
During JVMTI suspend/resume thread operations, the current check to determine if a thread is fully mounted is flaky. It depends on J9VMThread->theadObject which might change after getVMThread due to Java level changes, which are accepted as-is from the RI. The check to determine if a thread is fully mounted is moved into getVMThread. The check is updated to use the continuation state, which is more stable since the Continuation implementation is maintained within OpenJ9. Related: eclipse-openj9#17865 Related: eclipse-openj9#17869 Related: eclipse-openj9#18370 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
|
Old PR build: https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/4747. Resolved merge conflicts in Restarting the PR build: jenkins test sanity.functional,extended.openjdk aix,zlinux jdk21 |
|
This approach has side-effects. In some cases, a virtual thread is expected to be mounted but this approach shows it as unmounted. #18453 supersedes this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During JVMTI suspend/resume thread operations, the current check to
determine if a thread is fully mounted is flaky. It depends on
J9VMThread->theadObject which might change after getVMThread due to
Java level changes, which are accepted as-is from the RI.
The check to determine if a thread is fully mounted is moved into
getVMThread. The check is updated to use the continuation state, which
is more stable since the Continuation implementation is maintained
within OpenJ9.
Related: #17865
Related: #17869
Related: #18370