Add JVMTI synchronization in JVM_VirtualThreadHideFrames #18453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fengxue-IS @tajila Requesting your review. |
fengxue-IS
suggested changes
Nov 15, 2023
babsingh
force-pushed
the
main1
branch
2 times, most recently
from
8ef09a6
to
d5df8c0
Compare
J9VMThread->threadObject can be modified between JVM_VirtualThreadHideFrames's first invocation with hide=true and second invocation with hide=false. Synchronization to prevent JVMTI operations is acquired between these two invocations. This prevents JVMTI functions to see an unstable J9VMThread->threadObject. Related: eclipse-openj9#17865 Related: eclipse-openj9#17869 Related: eclipse-openj9#18370 Co-authored-by: Jack Lu <Jack.S.Lu@ibm.com> Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
commented
Nov 16, 2023
|
jenkins test sanity,extended.openjdk zlinux jdk21 |
|
Only known failures are seen in the builds, which are unrelated to this PR: |
|
@tajila PR builds look good. Requesting your review. |
tajila
approved these changes
Nov 19, 2023
|
@babsingh You'll need to triple deliver to 0.42 and 0.43 |
This was referenced Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
J9VMThread->threadObjectcan be modified betweenJVM_VirtualThreadHideFrames's first invocation withhide=trueandsecond invocation with
hide=false. Synchronization to prevent JVMTIoperations is acquired between these two invocations. This prevents
JVMTI functions to see an unstable
J9VMThread->threadObject.Related: #17865
Related: #17869
Related: #18370