Import the org.apache.commons.logging/io package instead of the bundle #280
Merged
zulus merged 1 commit intoeclipse-pdt:masterfrom Sep 13, 2025
Merged
Import the org.apache.commons.logging/io package instead of the bundle #280zulus merged 1 commit intoeclipse-pdt:masterfrom
zulus merged 1 commit intoeclipse-pdt:masterfrom
Conversation
47 tasks
merks
changed the title
HannesWell
approved these changes
Jan 24, 2025
Contributor
HannesWell
left a comment
HannesWell
left a comment
There was a problem hiding this comment.
Thank you Ed for this PR!
@zulus could you please have a look at this?
The hard requirement to the old commons-logging bundle with the specified name is really causing trouble in the sim-rel.
Comment on lines
-10
to
11
| Bundle-RequiredExecutionEnvironment: JavaSE-17 | ||
| Require-Bundle: org.apache.commons.logging, | ||
| org.apache.httpcomponents.httpclient;bundle-version="4.3.6", | ||
| Require-Bundle: org.apache.httpcomponents.httpclient;bundle-version="4.3.6", | ||
| org.apache.httpcomponents.httpcore;bundle-version="4.3.3", | ||
| com.google.gson;bundle-version="2.2.4", |
Contributor
There was a problem hiding this comment.
In general, to future-proof ourself against further changes like this, I think it would be good to use Import-Package for all dependencies that export their packages with a proper version, which is the case for most non-eclipse bundles.
Contributor
|
Any progress on this? This is now over one year old! |
- The latest version of these are named org.apache.commons.common-io and org.apache.commons.common-logging so better to avoid using the bundle name entirely. eclipse-simrel/simrel.build#438
zulus
force-pushed
the
pr-commons-logging
branch
from
20ababe to
2b5949d
Compare
Member
|
Thank You! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eclipse-simrel/simrel.build#438