Correct Cairo autoscaling setting in DPIUtil and remove setter #2031 #2032
Conversation
HeikoKlare
force-pushed
the
issue-2031
branch
2 times, most recently
from
d2e9e16 to
85d4b6f
Compare
Test Results 539 files + 108 539 suites +108 33m 59s ⏱️ + 15m 8s For more details on these failures, see this check. Results for commit d6bce22. ± Comparison against base commit 111b874. ♻️ This comment has been updated with latest results. |
|
Jenkins failure is due to https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5892 |
fedejeanne
left a comment
fedejeanne
left a comment
There was a problem hiding this comment.
The changes look good and make sense, just a nit comment.
bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/internal/DPIUtil.java
Outdated
Show resolved
Hide resolved
|
I would be confident with merging this change without a successful Jenkins run. GH actions succeeded at third attempt, Jenkins still fails. Would be nice to have this merged to avoid test failures in other PRs. @akurtakov would you agree with merging this? |
…e-platform#2031 Cairo auto-scaling was enabled in DPIUtil for every OS in a recent commit. This corrects the setting to be only applied on Linux/GTK and thus also issues arising from it. In addition, it removes the unnecessary setter for the auto-scaling and disables the tests that previously required it as they are meaningless without productive use of disabled Cairo auto-scale on Linux anyway. Fixes eclipse-platform#2031
|
Let's merge once GHA confirm it. |
|
Failing test is unrelated: #1843 |
3 participants
Cairo auto-scaling was enabled in DPIUtil for every OS in a recent commit. This corrects the setting to be only applied on Linux/GTK and thus also issues arising from it. In addition, it removes the unnecessary setter for the auto-scaling and disables the tests that previously required it as they are meaningless without productive use of disabled Cairo auto-scale on Linux anyway.
Fixes #2031