Fix for runWithAutoScaleValue #2034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fedejeanne
approved these changes
Apr 17, 2025
Member
fedejeanne
left a comment
fedejeanne
left a comment
There was a problem hiding this comment.
I tested this with all possible combinations of:
- (JVM-args)
-Dswt.autoScale:quarter,exact,integer,integer200,false,225and without the argument (i.e. rely on the default) - Windows (OS) zoom level:
100%,175%and225% - Monitor-specific scaling:
enabledanddisabled
I found no regressions and the PR fixes the issue.
Also, the 8 failing tests where introduced by #2030 and will be fixed by #2032
HeikoKlare
reviewed
Apr 17, 2025
bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/internal/DPIUtil.java
Show resolved
Hide resolved
This commit addresses and issue with DPIUtil#runWithAutoScaleValue. It only adapted DPIUtil#autoScaleValue temporarily. As DPIUtil#deviceZoom is directly affected by autoScaleValue, it is important to adjust it temporarily as well. fixes eclipse-platform/eclipse.platform.ui#2897
HeikoKlare
force-pushed
the
fix-DPIUtil-runWithAutoscale
branch
from
0d599f2 to
1824ac7
Compare
Contributor
|
Since Jenkins build failed for the PR: the subsequent master build after merging was successful has no new issues (https://ci.eclipse.org/releng/job/eclipse.platform.swt/job/master/1108/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses and issue with DPIUtil#runWithAutoScaleValue. It only adapted DPIUtil#autoScaleValue temporarily. As DPIUtil#deviceZoom is directly affected by autoScaleValue, it is important to adjust it temporarily as well.
fixes eclipse-platform/eclipse.platform.ui#2897