Add tests for drawing scaled image with GC#drawImage() #2623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
force-pushed
the
tests-imagedataatsizeprovider
branch
3 times, most recently
from
e8ad5ea to
1ef7e32
Compare
HeikoKlare
force-pushed
the
tests-imagedataatsizeprovider
branch
4 times, most recently
from
d924abc to
bf8a1b0
Compare
This adds test cases for the GC#drawImage(ImageIIII) method to draw a scaled version of the given image. With the introduction of the ImageDataAtSizeProvider, an image can be provided at the desired size instead of rescaling the best fitting zoomed image. The added tests cover those use cases and ensure that based on the kind of ImageDataProvider the appropriately scaled data is used. The tests for the ImageDataAtSizeProvider are limited to Windows until the implementation is extended to GTK and Cocoa.
HeikoKlare
force-pushed
the
tests-imagedataatsizeprovider
branch
from
bf8a1b0 to
77c5ac1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds test cases for the GC#drawImage(ImageIIII) method to draw a scaled version of the given image. With the introduction of the ImageDataAtSizeProvider, an image can be provided at the desired size instead of rescaling the best fitting zoomed image. The added tests cover those use cases and ensure that based on the kind of ImageDataProvider the appropriately scaled data is used.
The tests for the ImageDataAtSizeProvider are limited to Windows until the implementation is extended to GTK and Cocoa: