[MacOS] Support loading and drawing images at desired size #2619
Conversation
HeikoKlare
force-pushed
the
render-at-size-macos
branch
4 times, most recently
from
4bfac54 to
f610cc6
Compare
HeikoKlare
force-pushed
the
render-at-size-macos
branch
from
f610cc6 to
c26d738
Compare
| }); | ||
| } | ||
|
|
||
| @FunctionalInterface |
There was a problem hiding this comment.
the name does not make sense as it does not consume a handle , but an image
There was a problem hiding this comment.
Indeed. I just removed the interface as it's only an image consumer.
HeikoKlare
force-pushed
the
render-at-size-macos
branch
from
c26d738 to
adff2de
Compare
| return Optional.empty(); | ||
| } | ||
| Image image = new Image(device, imageData.get()); | ||
| NSBitmapImageRep representation = image.getRepresentation(100); |
There was a problem hiding this comment.
Shouldnt the image.getRepresentation be inside the if condition? also not very clear to me why do we get and remove representation at 100.
There was a problem hiding this comment.
Yes, it can be inside the if block. I fixed that with the latest commit.
We create the image based on image data in the line before (1881), which effectively creates an image with a 100% representation (out of the given image data). For that reason, we retrieve the representation at that same zoom. We then use the createRepFromSourceAndApplyFlag to apply the style flag on that representation (which adds another representation with that styling to the image), so that we need to remove the original (unstyled) representation afterwards.
HeikoKlare
force-pushed
the
render-at-size-macos
branch
from
adff2de to
2b33ae5
Compare
With the support of SVGs and the addition of the ImageDataAtSizeProvider, it is possible for many Image instances to provide a handle that represents the image at sharply rendered specific size in addition to the existing support of providing an image at different zooms of a base size. This change adds according support to the MacOS implementations of GC and Image. The GC#drawImage() method accepting only destination position and size now makes use of enhanced Image capabilities to load the image at the desired size if possible instead of just using the best fitting zoomed handle.
HeikoKlare
force-pushed
the
render-at-size-macos
branch
from
2b33ae5 to
6af993c
Compare
2 participants
With the support of SVGs and the addition of the ImageDataAtSizeProvider, it is possible for many Image instances to provide a handle that represents the image at sharply rendered specific size in addition to the existing support of providing an image at different zooms of a base size.
This change adds according support to the MacOS implementations of GC and Image. The GC#drawImage() method accepting only destination position and size now makes use of enhanced Image capabilities to load the image at the desired size if possible instead of just using the best fitting zoomed handle.
Can be tested with the snippets provided for the Windows implementation PR: