Skip to content

Conversation

arunjose696
Copy link
Contributor

@arunjose696 arunjose696 changed the title Automatic refactoring: move Win32DPIUtils.pointToPixel(size,zoom) to … Automatic refactoring: move Win32DPIUtils.pointToPixel(size,zoom) to DPIUtil Oct 14, 2025
Copy link
Contributor

github-actions bot commented Oct 14, 2025

Test Results

  115 files  ±0    115 suites  ±0   13m 31s ⏱️ + 2m 45s
4 547 tests +1  4 532 ✅ +1  15 💤 ±0  0 ❌ ±0 
  311 runs  ±0    308 ✅ ±0   3 💤 ±0  0 ❌ ±0 

Results for commit 6c9839b. ± Comparison against base commit d884e6b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving this to DPIUtil seems reasonable to me, as pixelToPoint is also part of that class. I just have minor comments for proper refactoring and cleanup.

…DPIUtils

The change is required to do pointToPixel conversions in GTK and MACOS
which would be required in follow up PRs
@arunjose696 arunjose696 force-pushed the arunjose696/MovePointToPixel branch from ac8de0d to 6c9839b Compare October 15, 2025 11:17
@HeikoKlare HeikoKlare merged commit 4df1e42 into eclipse-platform:master Oct 15, 2025
17 checks passed
@HeikoKlare HeikoKlare deleted the arunjose696/MovePointToPixel branch October 15, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

move Win32DPIUtils.pointToPixel(size,zoom) to DPIUtil

2 participants