Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows11: Missing Font-Properties-File in Bundle org.eclipse.jface #488

Closed
Rainer7000 opened this issue Dec 15, 2022 · 9 comments
Closed

Windows11: Missing Font-Properties-File in Bundle org.eclipse.jface #488

Rainer7000 opened this issue Dec 15, 2022 · 9 comments
Labels
help wanted Extra attention is needed Windows Happens on Windows OS

Comments

@Rainer7000
Copy link
Contributor

There is no Default-Font-Properties-File in Bunlde org.eclipse.jface for Windows 11

org.eclipse.jface_3.28.0.v20221024-1426\org\eclipse\jface\resource\jfacefonts_windows11.properties

As a result the default-fonts look outdated under Windows11 due to the fallbacks in FontRegistry#readResourceBundle.
@iloveeclipse
Copy link
Member

@ConradGroth : you provided via 4c9741c last change in this area.
Could you check what is needed for Windows 11?
Is this same as for 10?

@iloveeclipse iloveeclipse added help wanted Extra attention is needed Windows Happens on Windows OS labels Dec 16, 2022
@ConradGroth
Copy link
Contributor

@iloveeclipse sorry, I don't have Windows 11 running. I cannot prove, what's needed here.

@iloveeclipse
Copy link
Member

Thanks Conrad.
@SyntevoAlex : something for you?

@SyntevoAlex
Copy link
Member

Sorry, I'm only focused on SWT.

@SyntevoAlex
Copy link
Member

@ConradGroth with VirtualBox 7.0, Win11 can easily be installed in a VM.

@Rainer7000
Copy link
Contributor Author

I tried patching the bundle locally by just copying jfacefonts_windows10.properties to jfacefonts_windows11.properties. As far as I can tell the fonts look good. The main issue was that the default text-font was set to Courier instead of the more modern Consolas in Windows 10 and 11.

Rainer7000 added a commit to Rainer7000/eclipse.platform.ui_Windows11Fonts that referenced this issue May 4, 2023
@Rainer7000
Windows11 default fonts to fix issue eclipse-platform#488
cc58be7 
Issue:
eclipse-platform#488
@Rainer7000 Rainer7000 mentioned this issue May 4, 2023
Merged
Rainer7000 added a commit to Rainer7000/eclipse.platform.ui_Windows11Fonts that referenced this issue May 4, 2023
@Rainer7000
Windows11 default fonts to fix issue eclipse-platform#488 (#1)
2cb3008 
Issue:
eclipse-platform#488
@Rainer7000 Rainer7000 mentioned this issue May 4, 2023
Merged
Rainer7000 added a commit to Rainer7000/eclipse.platform.ui_Windows11Fonts that referenced this issue May 24, 2023
@Rainer7000
Windows11 default fonts to fix issue eclipse-platform#488 (#1)
596a5c6 
Issue:
eclipse-platform#488
Rainer7000 added a commit to Rainer7000/eclipse.platform.ui_Windows11Fonts that referenced this issue Jun 13, 2023
@Rainer7000
Windows11 default fonts to fix issue eclipse-platform#488 (#1)
93a8714 
Issue:
eclipse-platform#488
vogella pushed a commit to Rainer7000/eclipse.platform.ui_Windows11Fonts that referenced this issue Nov 21, 2023
@Rainer7000 @jukzi @vogella
Windows11 default fonts to fix issue eclipse-platform#488 (#1)
59cb6cf 
Issue:
eclipse-platform#488

Update bundles/org.eclipse.jface/src/org/eclipse/jface/resource/jfacefonts_windows11.properties

Co-Authored-By: Jörg Kubitz <51790620+jukzi@users.noreply.github.com>
@vogella
Copy link
Contributor

vogella commented Nov 21, 2023

I have no windows at the moment to test, can you add "before" and "after" screenshots to this issue?

vogella pushed a commit to Rainer7000/eclipse.platform.ui_Windows11Fonts that referenced this issue Dec 14, 2023
@Rainer7000 @jukzi @vogella
Windows11 default fonts to fix issue eclipse-platform#488 (#1)
3bd8afa 
Issue:
eclipse-platform#488

Update bundles/org.eclipse.jface/src/org/eclipse/jface/resource/jfacefonts_windows11.properties

Co-Authored-By: Jörg Kubitz <51790620+jukzi@users.noreply.github.com>
vogella pushed a commit that referenced this issue Dec 15, 2023
@Rainer7000 @jukzi @vogella
Windows11 default fonts to fix issue #488 (#1)
949383f 
Issue:
#488

Update bundles/org.eclipse.jface/src/org/eclipse/jface/resource/jfacefonts_windows11.properties

Co-Authored-By: Jörg Kubitz <51790620+jukzi@users.noreply.github.com>
amartya4256 pushed a commit to amartya4256/eclipse.platform.ui that referenced this issue Feb 8, 2024
@Rainer7000 @jukzi @amartya4256
Windows11 default fonts to fix issue eclipse-platform#488 (#1)
617c0d8 
Issue:
eclipse-platform#488

Update bundles/org.eclipse.jface/src/org/eclipse/jface/resource/jfacefonts_windows11.properties

Co-Authored-By: Jörg Kubitz <51790620+jukzi@users.noreply.github.com>
@iloveeclipse
Copy link
Member

Is this fixed via #744 or is something left open?

@Rainer7000
Copy link
Contributor Author

Yes this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed Windows Happens on Windows OS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@vogella @iloveeclipse @ConradGroth @SyntevoAlex @Rainer7000