Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows11 default font configuration. fixes #488 #744

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Add Windows11 default font configuration. fixes #488 #744

merged 1 commit into from
Dec 15, 2023

Conversation

Rainer7000
Copy link
Contributor

Issue:
#488

@akurtakov
Copy link
Member

Please sign ECA or otherwise your patch can't be incorporated. https://accounts.eclipse.org/legal/eca/validation/153038

@jukzi jukzi changed the title Windows11 default fonts to fix issue #488 (#1) Add Windows11 default font configuration. fixes #488 May 8, 2023
@iloveeclipse
Copy link
Member

@Rainer7000 : thanks for patches. Please

  1. Avoid merge commits - instead, rebase your changes on top of master.
  2. Create one commit per PR - so please rebase your changes and squash into one commit
  3. Update commit message, see https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#commit-message-recommendations

@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2023 •
edited
Loading

Test Results

     900 files  +       1       900 suites  +1   1h 5m 59s ⏱️ + 27m 43s
  7 469 tests ±       0    7 316 ✔️ +       1  153 💤 ±    0  0 ❌  - 1 
23 556 runs  +1 576  23 047 ✔️ +1 457  509 💤 +120  0 ❌  - 1 

Results for commit 3bd8afa. ± Comparison against base commit 188f7fb.

♻️ This comment has been updated with latest results.

@jukzi
Copy link
Contributor

jukzi commented May 24, 2023

please squash changes to a single commit.

@Rainer7000
Copy link
Contributor Author

Is there anyone from the platform-team who can help me commit this patch please ?
It's only a simple ascii-file with some default-fonts and the commit ist stuck for months now on "Code Analysis Queued — Waiting to run this check...".

@vogella
Copy link
Contributor

vogella commented Nov 21, 2023

We are currently in a freeze period so you will have to wait 1-2 weeks more.

@vogella
Copy link
Contributor

vogella commented Nov 21, 2023

Sorry.

@vogella vogella self-requested a review November 21, 2023 14:04
@Rainer7000
Copy link
Contributor Author

For comparison here are screeshots from before the patch, where Jface defaults to Courier new Font for Code or the Default-Text-Font:
before

After the patch the default Text-Font under Windows11 is Consolas (same as under Windows 10):
after

@Rainer7000 @jukzi @vogella
Windows11 default fonts to fix issue eclipse-platform#488 (#1)
3bd8afa 
Issue:
eclipse-platform#488

Update bundles/org.eclipse.jface/src/org/eclipse/jface/resource/jfacefonts_windows11.properties

Co-Authored-By: Jörg Kubitz <51790620+jukzi@users.noreply.github.com>
@vogella
Copy link
Contributor

vogella commented Dec 15, 2023 •
edited
Loading

Thanks @Rainer7000 finally tested on Win11, looks OK to me (not better, not worse for me but as a rare Window user I'm not used to the "right" font in Windows).

@Rainer7000 can you verify in the next successful I-build (currently we are having problems to get one, most likely due to eclipse-jdt/eclipse.jdt.core#1394) ? https://download.eclipse.org/eclipse/downloads/

@vogella vogella merged commit 949383f into eclipse-platform:master Dec 15, 2023
14 checks passed
@Rainer7000
Copy link
Contributor Author

I have successfully checked the expected default jface-fonts under Windows 11 in Build I20231218-1800.

@vogella
Copy link
Contributor

vogella commented Dec 20, 2023

Thanks @Rainer7000

@iloveeclipse iloveeclipse mentioned this pull request May 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jukzi jukzi jukzi left review comments

@vogella vogella Awaiting requested review from vogella

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Rainer7000 @akurtakov @iloveeclipse @jukzi @vogella