Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove org.json dependency #1098

Closed
barthanssens opened this issue Oct 8, 2018 · 3 comments · Fixed by #2127
Closed

Remove org.json dependency #1098

barthanssens opened this issue Oct 8, 2018 · 3 comments · Fixed by #2127
Assignees
@abrokenjester
Labels
🐞 bug issue is a bug
Milestone
3.1.4

Comments

@barthanssens
Copy link
Contributor

Current org.json dependency is somewhat outdated, and might not be used at all in some subprojects.

It seems to be used in a few places in the rdf4j-tools subproject for creating XmlHhttpRequests, maybe it can be replaced with a javax.json or com.fasterxml.jackson (which may eliminate this org.json dependency)
@barthanssens barthanssens added the 📶 enhancement issue is a new feature or improvement label Oct 8, 2018
@barthanssens barthanssens self-assigned this Oct 8, 2018
@abrokenjester abrokenjester changed the title Upgrade or remove org.json dependency Remove org.json dependency Apr 22, 2020
@abrokenjester
Copy link
Contributor

I've just been notified that we never logged a CQ for this dependency. Also, somewhat worryingly: a CQ is likely to not be approved, because this package has a license that is not fully OSS-compatible (in particular, it has a "only use for good not evil" clause in it somewhere).

We should expedite removing this dependency as soon as possible. It may block our next release.

@abrokenjester abrokenjester added ✋ CQ-Pending requires a CQ to be approved 🐞 bug issue is a bug and removed 📶 enhancement issue is a new feature or improvement labels Apr 22, 2020
@abrokenjester abrokenjester self-assigned this Apr 22, 2020
@abrokenjester abrokenjester added this to the 3.1.4 milestone Apr 22, 2020
@abrokenjester
Copy link
Contributor

We may need to cherry pick the fix we do for this and retroactively apply it to some older releases as well, at least the ones that we wish to keep available for download.

abrokenjester added a commit that referenced this issue Apr 24, 2020
@abrokenjester
GH-1098 removed org.json dep, replaced usage with Jackson
a72521f
@abrokenjester abrokenjester mentioned this issue Apr 24, 2020
Merged
4 tasks
@abrokenjester
Copy link
Contributor

See discussion on https://dev.eclipse.org/ipzilla/show_bug.cgi?id=21981

abrokenjester added a commit that referenced this issue Apr 24, 2020
@abrokenjester
GH-1098 removed org.json dep, replaced usage with Jackson (#2127)
422b3b6
@abrokenjester abrokenjester removed the ✋ CQ-Pending requires a CQ to be approved label Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abrokenjester abrokenjester

Labels
🐞 bug issue is a bug
Projects
None yet
Milestone
3.1.4
Development

Successfully merging a pull request may close this issue.

GH-1098 removed org.json dep, replaced usage with Jackson eclipse-rdf4j/rdf4j
2 participants
@abrokenjester @barthanssens