GH-1098 removed org.json dep, replaced usage with Jackson #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review at your earliest convenience - I would like this merged so I can go ahead and fix our release artifacts as soon as possible. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved: #1098
Briefly describe the changes proposed in this PR:
Removed all references to org.json package. Replaced its use in the workbench with equivalent Jackson functionality.
I've not written unit tests because the servlet code is rather tangled, and writing tests for it is a chore I just can't face at the moment. However, I compiled and ran the modified workbench, and verified that executing queries, saving queries, and deleting data still all work as expected.
PR Author Checklist:
Note: we merge all feature pull requests using squash and merge. See RDF4J git merge strategy for more details.