Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hydra vocabulary #1190

Closed
barthanssens opened this issue Dec 3, 2018 · 6 comments · Fixed by #2291
Closed

Add Hydra vocabulary #1190

barthanssens opened this issue Dec 3, 2018 · 6 comments · Fixed by #2291
Assignees
@navdhaagarwal
Labels
📶 enhancement issue is a new feature or improvement good first issue issue is a good choice for getting started as an rdf4j contributor M1 Fixed in milestone 1
Milestone
3.3.0

Comments

@barthanssens
Copy link
Contributor

Add a vocabulary class for Hydra (http://www.hydra-cg.com/spec/latest/core/), which can be used by hypermedia APIs (like a semantic version of Swagger / OpenAPI) such as Linked Data Fragments (http://linkeddatafragments.org/specification/)
@barthanssens barthanssens added 📶 enhancement issue is a new feature or improvement good first issue issue is a good choice for getting started as an rdf4j contributor labels Dec 3, 2018
navdhaagarwal pushed a commit to navdhaagarwal/rdf4j that referenced this issue May 28, 2020
eclipse-rdf4jGH-1190: Added HYDRA class
c0a5d82 
Signed-off-by: navdhaagarwal <navdha16250@iiitd.ac.in>
@navdhaagarwal
Copy link
Contributor

Hi!
We (me and @shubhi0108) have started working on this issue. I have added the HYDRA class and have added all the classes and properties as stated in http://www.hydra-cg.com/spec/latest/core/. We'll add the tests soon. Please let us know what else needs to be done.
Thank you!

navdhaagarwal pushed a commit to navdhaagarwal/rdf4j that referenced this issue May 28, 2020
eclipse-rdf4jGH-1190: Added HYDRA class
22fec99 
Signed-off-by: navdhaagarwal <navdha16250@iiitd.ac.in>
navdhaagarwal pushed a commit to navdhaagarwal/rdf4j that referenced this issue May 28, 2020
eclipse-rdf4jGH-1190: Added a test
5bae374 
Signed-off-by: navdhaagarwal <navdha16250@iiitd.ac.in>
@barthanssens barthanssens added this to the 3.3.0 milestone May 28, 2020
navdhaagarwal pushed a commit to navdhaagarwal/rdf4j that referenced this issue May 28, 2020
eclipse-rdf4jGH-1190: Added HYDRA class
8b89378 
Signed-off-by: navdhaagarwal <navdha16250@iiitd.ac.in>

eclipse-rdf4jGH-1190: Added a test

Signed-off-by: navdhaagarwal <navdha16250@iiitd.ac.in>
@navdhaagarwal
Copy link
Contributor

Hi!
We have added the test and squashed the commits. I'll link the pull request. Please let us know the modification required.
Thank you.

@navdhaagarwal navdhaagarwal mentioned this issue May 28, 2020
Merged
5 tasks
@barthanssens
Copy link
Contributor Author

Thanks for your help, looks good to me !

@barthanssens
Copy link
Contributor Author

Perhaps one minor comment: since it is an enhancement (not a bug), could you make the pull request on the develop branch instead of the master branch ?

No need no create a new pull request, you should be able to just go to #2291, click on the "edit" button and change the base from "base: master" to "base: develop")

@navdhaagarwal , @shubhi0108

And could you also add your full names as a comment in #2235 , so we can add them to the release notes ?

@navdhaagarwal navdhaagarwal mentioned this issue May 29, 2020
Closed
abrokenjester pushed a commit that referenced this issue May 29, 2020
GH-1190: Added HYDRA class (#2291)
8165433 
Signed-off-by: navdhaagarwal <navdha16250@iiitd.ac.in>

GH-1190: Added a test

Signed-off-by: navdhaagarwal <navdha16250@iiitd.ac.in>
@navdhaagarwal
Copy link
Contributor

Hi,
Please let me know whether some work is left regarding this issue.
Thanks

@abrokenjester
Copy link
Contributor

Ah, no, thanks, I think this is done! Thanks again :)

@hmottestad hmottestad added the M1 Fixed in milestone 1 label Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@navdhaagarwal navdhaagarwal

Labels
📶 enhancement issue is a new feature or improvement good first issue issue is a good choice for getting started as an rdf4j contributor M1 Fixed in milestone 1
Projects
None yet
Milestone
3.3.0
Development

Successfully merging a pull request may close this issue.

GH-1190: Added HYDRA class navdhaagarwal/rdf4j
4 participants
@abrokenjester @hmottestad @barthanssens @navdhaagarwal