Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1190: Added HYDRA class #2291

Conversation

navdhaagarwal
Copy link
Contributor

@navdhaagarwal navdhaagarwal commented May 28, 2020

GitHub issue resolved: #1190

Briefly describe the changes proposed in this PR:

Added the vocabulary class for HYDRA (http://www.hydra-cg.com/spec/latest/core/)


PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change
  • every commit has been signed off

Note: we merge all feature pull requests using squash and merge. See RDF4J git merge strategy for more details.

Signed-off-by: navdhaagarwal <navdha16250@iiitd.ac.in>

eclipse-rdf4jGH-1190: Added a test

Signed-off-by: navdhaagarwal <navdha16250@iiitd.ac.in>
Copy link
Contributor

@barthanssens barthanssens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the issue 1190, code looks good (thanks !), but it would be nice if the PR could be based on develop instead of master (can simply be changed on github, so no need to create a new PR)

The reason is that we like to add new features / enhancements on develop for a new release, and only use master for bug fixes in small patch releases.

@abrokenjester abrokenjester changed the base branch from master to develop May 29, 2020 00:52
@abrokenjester
Copy link
Contributor

As mentioned in the issue 1190, code looks good (thanks !), but it would be nice if the PR could be based on develop instead of master (can simply be changed on github, so no need to create a new PR)

The reason is that we like to add new features / enhancements on develop for a new release, and only use master for bug fixes in small patch releases.

Good point @barthanssens. I've changed it for this PR, so no need for any action on your part here @navdhaagarwal - but it's a good one to keep in mind: if the issue you're fixing is labeled as an enhancement, target your PR against the develop branch. Only issues labeled 'bug' should go to master. No big deal if you forget either: if you want to change this for an existing PR, click the 'edit' button to the right of the PR title, and then select a new base branch in the little dropdown.

@navdhaagarwal
Copy link
Contributor Author

navdhaagarwal commented May 29, 2020

Thank you @jeenbroekstra and @barthanssens. I will keep this in mind in the future.
Please let us know if there are some modifications required.

@abrokenjester abrokenjester merged commit 8165433 into eclipse-rdf4j:develop May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Hydra vocabulary
3 participants