-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify SPARQL algebra Projection handling #2990
Labels
Milestone
Comments
abrokenjester
added
📶 enhancement
issue is a new feature or improvement
📦 sparql
affects the SPARQL parser / engine
labels
Apr 12, 2021
abrokenjester
added
the
⛔ Not backwards compatible
A change that breaks backwards compatibility and needs a major release
label
Apr 12, 2021
5 tasks
Alternatively we should look into removing the Extension where the projection itself already takes care of the aliasing. Also as a possible complication is that handling of construct queries currently heavily relies on projection itself supporting aliasing. |
abrokenjester
removed
the
⛔ Not backwards compatible
A change that breaks backwards compatibility and needs a major release
label
Feb 28, 2022
abrokenjester
added a commit
that referenced
this issue
Feb 28, 2022
5 tasks
abrokenjester
added a commit
that referenced
this issue
Feb 28, 2022
abrokenjester
added a commit
that referenced
this issue
Mar 4, 2022
abrokenjester
added a commit
that referenced
this issue
Mar 6, 2022
abrokenjester
added a commit
that referenced
this issue
Mar 6, 2022
patrickwyler
pushed a commit
to patrickwyler/rdf4j
that referenced
this issue
Jun 20, 2022
patrickwyler
pushed a commit
to patrickwyler/rdf4j
that referenced
this issue
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Related to #2985
For the following query:
We produce the following algebra tree:
Note that the aliasing of "foo" to "bar" is represented twice here: once as an
ExtensionElem
, once as an aliasedProjectionElem
.The
ProjectionElem
in our algebra predates sparql and its evaluation (inProjectionIterator
) has mechanisms to map source bindings to target bindings that we effectively don't need anymore, since the mapping is handled by the extension already. We should look into simplifying this part of the algebra and remove the distinction between source and target name in theProjectionElem
. This will make the intent of the algebra clearer, and likely allow us to improve performance as well, as the ProjectionIterator can be simplified.The text was updated successfully, but these errors were encountered: