Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension operation disappears for some queries in rdf4j v4 #4066

Closed
abrokenjester opened this issue Jul 17, 2022 Discussed in #3991 · 1 comment · Fixed by #4122
Closed

Extension operation disappears for some queries in rdf4j v4 #4066

abrokenjester opened this issue Jul 17, 2022 Discussed in #3991 · 1 comment · Fixed by #4122
Assignees
Labels
🐞 bug issue is a bug 📦 sparql affects the SPARQL parser / engine
Milestone

Comments

@abrokenjester
Copy link
Contributor

Discussed in #3991

Originally posted by apano-on June 15, 2022
It seems like the operation with the extension has disappeared in at least one scenario for rdf4j v4.0.0 (as well as v4.0.2). Is there a rationale for this change?

Steps to reproduce

The following query is translated differently in the new version of rdf4j

SELECT (?l AS ?v)
WHERE { ?s rdfs:label ?l . }
ORDER BY ?v

Current Behavior (rdf4j v4.0.2 translation/algebra tree)

QueryRoot
   Projection
      ProjectionElemList
         ProjectionElem "l" AS "v"
      Order
         OrderElem (ASC)
            Var (name=v)
         StatementPattern
            Var (name=s)
            Var (name=_const_9285ccfc_uri, value=http://www.w3.org/2000/01/rdf-schema#label, anonymous)
            Var (name=l)

Expected Behavior (rdf4j v3 translation/algebra tree)

Projection
   ProjectionElemList
      ProjectionElem "l" AS "v"
   Order
      OrderElem (ASC)
         Var (name=v)
      Extension
         ExtensionElem (v)
            Var (name=l)
         StatementPattern
            Var (name=s)
            Var (name=_const_9285ccfc_uri, value=http://www.w3.org/2000/01/rdf-schema#label, anonymous)
            Var (name=l)
```</div>
@abrokenjester abrokenjester added 🐞 bug issue is a bug 📦 sparql affects the SPARQL parser / engine labels Jul 17, 2022
@abrokenjester abrokenjester added this to the 4.1.0 milestone Jul 17, 2022
@hmottestad hmottestad modified the milestones: 4.1.0, 4.2.0 Jul 31, 2022
@abrokenjester abrokenjester self-assigned this Aug 19, 2022
@abrokenjester abrokenjester modified the milestones: 4.2.0, 4.1.1 Aug 19, 2022
@abrokenjester
Copy link
Contributor Author

abrokenjester commented Aug 20, 2022

I'm going to partially revert some of the changes made for GH-2990, and consistently use an extension again. This seems to be more in line with the intent of the SPARQL spec (see https://www.w3.org/TR/sparql11-query/#sparqlSelectExpressions in particular).

abrokenjester added a commit that referenced this issue Aug 20, 2022
This makes it clearer why this mechanism exists in addition to Extension
elements.
abrokenjester added a commit that referenced this issue Aug 20, 2022
This makes it clearer why this mechanism exists in addition to Extension
elements.
abrokenjester added a commit that referenced this issue Aug 21, 2022
This makes it clearer why this mechanism exists in addition to Extension
elements.
abrokenjester added a commit that referenced this issue Aug 21, 2022
This makes it clearer why this mechanism exists in addition to Extension
elements.
abrokenjester added a commit that referenced this issue Aug 21, 2022
This makes it clearer why this mechanism exists in addition to Extension
elements.
abrokenjester added a commit that referenced this issue Aug 21, 2022
This makes it clearer why this mechanism exists in addition to Extension
elements.
abrokenjester added a commit that referenced this issue Aug 21, 2022
This makes it clearer why this mechanism exists in addition to Extension
elements.
abrokenjester added a commit that referenced this issue Aug 21, 2022
This makes it clearer why this mechanism exists in addition to Extension
elements.
abrokenjester added a commit that referenced this issue Aug 21, 2022
This makes it clearer why this mechanism exists in addition to Extension
elements.
abrokenjester added a commit that referenced this issue Aug 21, 2022
This makes it clearer why this mechanism exists in addition to Extension
elements.
abrokenjester added a commit that referenced this issue Aug 27, 2022
This makes it clearer why this mechanism exists in addition to Extension
elements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug issue is a bug 📦 sparql affects the SPARQL parser / engine
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants