Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-4066 re-introduce use of Extension for all select expressions #4122

Merged
merged 3 commits into from
Aug 27, 2022
Merged

GH-4066 re-introduce use of Extension for all select expressions #4122

merged 3 commits into from
Aug 27, 2022

Conversation

abrokenjester
Copy link
Contributor

@abrokenjester abrokenjester commented Aug 20, 2022 •
edited
Loading

GitHub issue resolved: #4066

Briefly describe the changes proposed in this PR:

  • re-introduce use of Extension for all non-var SELECT expressions
  • refactor of ProjectionElem and ProjectionElemList to clarify use of name vs targetName

PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

@abrokenjester abrokenjester force-pushed the GH-4066-select-expression-extension branch from c8b8382 to 3bb40c5 Compare August 20, 2022 22:52
@abrokenjester abrokenjester marked this pull request as ready for review August 20, 2022 22:52
@abrokenjester abrokenjester marked this pull request as draft August 20, 2022 23:13
@abrokenjester abrokenjester force-pushed the GH-4066-select-expression-extension branch 4 times, most recently from a68d856 to 2118436 Compare August 21, 2022 00:13
@abrokenjester abrokenjester marked this pull request as ready for review August 21, 2022 00:14
@abrokenjester abrokenjester force-pushed the GH-4066-select-expression-extension branch 4 times, most recently from 2025e29 to c05a8dc Compare August 21, 2022 05:01
@abrokenjester
GH-4066 refactor ProjectionElem to clarify use of targetName
fc6c200 
This makes it clearer why this mechanism exists in addition to Extension
elements.
@abrokenjester abrokenjester force-pushed the GH-4066-select-expression-extension branch from c05a8dc to fc6c200 Compare August 21, 2022 05:28
@abrokenjester
Copy link
Contributor Author

Ok, all builds succeed but the test report step fails?!

@abrokenjester
Copy link
Contributor Author

@hmottestad it looks as it failed a while back when there were failing tests but now is stuck because it doesn't get re-run when there are no test failures? I'm on my phone so may be missing something here.

@abrokenjester
Copy link
Contributor Author

Yay, empty commit to force a frew build solved it (when a re-run of the build didnt).

@abrokenjester abrokenjester merged commit c607df2 into main Aug 27, 2022
@abrokenjester abrokenjester deleted the GH-4066-select-expression-extension branch August 27, 2022 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmottestad hmottestad Awaiting requested review from hmottestad

@JervenBolleman JervenBolleman Awaiting requested review from JervenBolleman

@damyan-ognyanov damyan-ognyanov Awaiting requested review from damyan-ognyanov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extension operation disappears for some queries in rdf4j v4
1 participant
@abrokenjester