Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typing to Command in Hello World Template #115

Closed
JonasHelming opened this issue Sep 21, 2021 · 0 comments · Fixed by #117
Closed

Add typing to Command in Hello World Template #115

JonasHelming opened this issue Sep 21, 2021 · 0 comments · Fixed by #117
Assignees
@JonasHelming
Labels
good first issue

Comments

@JonasHelming
Copy link
Contributor

JonasHelming commented Sep 21, 2021 •
edited by vince-fugnitto
Loading

Description

We should add proper typing when registering the HelloWorldCommand for downstream adopters more easily defining commands:

generator-theia-extension/templates/hello-world/contribution.ts

Line 5 in 2b0ad9e

export const <%= params.extensionPrefix %>Command = {

Should be updated to:

export const <%= params.extensionPrefix %>Command: Command = {
@JonasHelming JonasHelming self-assigned this Sep 21, 2021
@JonasHelming JonasHelming mentioned this issue Sep 21, 2021
Merged
JonasHelming added a commit to JonasHelming/generator-theia-extension that referenced this issue Sep 27, 2021
@JonasHelming
Added typing to Command in Hello World Template
d797988 
fixed eclipse-theia#115

Contributed on behalf of STMicroelectronics

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
@JonasHelming JonasHelming mentioned this issue Sep 27, 2021
Merged
JonasHelming added a commit to JonasHelming/generator-theia-extension that referenced this issue Sep 27, 2021
@JonasHelming
Merge branch 'master' into eclipse-theiaGH-115
ad204cf
JonasHelming added a commit to JonasHelming/generator-theia-extension that referenced this issue Sep 27, 2021
@JonasHelming
Merge branch 'master' into eclipse-theiaGH-115
9467b65 
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
JonasHelming added a commit to JonasHelming/generator-theia-extension that referenced this issue Sep 27, 2021
@JonasHelming
Merge branch 'master' into eclipse-theiaGH-115
78f3e94 
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
JonasHelming added a commit that referenced this issue Oct 5, 2021
@JonasHelming
Added typing to Command in Hello World Template (#117)
7fb45d6 
fixed #115

Contributed on behalf of STMicroelectronics

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JonasHelming JonasHelming

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added typing to Command in Hello World Template JonasHelming/generator-theia-extension
2 participants
@JonasHelming @vince-fugnitto