Added typing to Command in Hello World Template #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed eclipse-theia#115 Contributed on behalf of STMicroelectronics Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
JonasHelming
changed the title
JonasHelming
force-pushed
the
GH-115
branch
from
ad204cf
to
9467b65
Compare
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
JonasHelming
force-pushed
the
GH-115
branch
from
9467b65
to
78f3e94
Compare
JonasHelming
changed the title
There was a problem hiding this comment.
@JonasHelming the change look good to me 👍 the typings should help devs.
Please be sure to squash and remove the merge commit, I believe there are currently conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #115
Contributed on behalf of STMicroelectronics
Signed-off-by: Jonas Helming jhelming@eclipsesource.com