Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Resource Sequence Index is not start from available number when create untitled file #11346

Closed
yiliang114 opened this issue Jun 26, 2022 · 0 comments · Fixed by #11347
Closed

The Resource Sequence Index is not start from available number when create untitled file #11346

yiliang114 opened this issue Jun 26, 2022 · 0 comments · Fixed by #11347
Labels
editor issues related to the editor

Comments

@yiliang114
Copy link
Contributor

Bug Description:

Steps to Reproduce:

  1. yarn & yarn browser build & yarn browser start.
  2. Open http://localhost:3000/ and open any workspace.
  3. Use alt + n to call NEW_FILE command some times, we can see tab named Untitled-${index} one by one. And we can notice the number in label is start from 0 rather then 1(vscode is started from 1).
  4. Call NEW_FILE command again after close some older Untitled file, it should used the number which is closed just now like vscode.

Refer to the following screenshots:

vscode behavior:

QQ20220626-180642

theia behavior:

QQ20220626-181132

Additional Information

  • Operating System: macos
  • Theia Version: 1.26.0 the latest commit id is 0e05d0a
yiliang114 added a commit to yiliang114/theia that referenced this issue Jun 26, 2022
@yiliang114
fix(commad): close eclipse-theia#11346, use available number to label…
ca34bb3 
… when create untitled file
@yiliang114 yiliang114 mentioned this issue Jun 26, 2022
Merged
1 task
@msujew msujew added the editor issues related to the editor label Jun 27, 2022
yiliang114 added a commit to yiliang114/theia that referenced this issue Jun 27, 2022
@yiliang114
fix(UntitledResourceResolver): optimize createUntitledURI function (e…
4a10897 
…clipse-theia#11346)

Signed-off-by: yiliang114 <1204183885@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editor issues related to the editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(commad): close #11346, use available number to label when create … yiliang114/theia
2 participants
@msujew @yiliang114