fix(commad): close #11346, use available number to label when create … #11347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when create untitled file
msujew
added
editor
msujew
reviewed
Jun 27, 2022
There was a problem hiding this comment.
@yiliang114 Thank you for your first contribution!
I believe we can greatly simplify this change and cut down on the logic duplication. See below on how we could accomplish this.
…clipse-theia#11346) Signed-off-by: yiliang114 <1204183885@qq.com>
Signed-off-by: yiliang114 <1204183885@qq.com>
…fix/new-untitled-file-index
msujew
reviewed
Jun 27, 2022
Co-authored-by: Mark Sujew <mark.sujew@typefox.io>
Signed-off-by: yiliang114 <1204183885@qq.com>
|
What did I ignore caused two CI run failed? I try to find errors in log, get nothing useful but large empty section below limited content.
|
Signed-off-by: yiliang114 <1204183885@qq.com>
msujew
reviewed
Jun 28, 2022
msujew
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
close #11346
after change:
How to test
http://localhost:3000/and open any workspace.alt + nto callNEW_FILEcommand some times, we can see tab namedUntitled-${index}one by one. The number in label is start from1like vscode.NEW_FILEcommand again after close some older Untitled file, it will use the number which is closed just now like vscode.Review checklist
Reminder for reviewers