Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug: add missing localization for disassembly #11932

Closed
vince-fugnitto opened this issue Nov 29, 2022 · 2 comments · Fixed by #11939 · May be fixed by magnologan/theia#8, magnologan/theia#9 or magnologan/theia#10
Closed

debug: add missing localization for disassembly #11932

vince-fugnitto opened this issue Nov 29, 2022 · 2 comments · Fixed by #11939 · May be fixed by magnologan/theia#8, magnologan/theia#9 or magnologan/theia#10
Labels
beginners issues that are perfect for beginners disassembly issues related to the disassembly view good first issue good first issues for new contributors localization issues related to localization/internalization/nls

Comments

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Nov 29, 2022 •
edited
Loading

Bug Description:

The framework should update the disassembly-view widget to include a localization for it's label.

theia/packages/debug/src/browser/disassembly-view/disassembly-view-widget.ts

Line 85 in 2ec7d87

this.title.label = 'Disassembly';

The change should be something like the following:

this.title.label = nls.localize('theia/debug/disassembly-view/disassembly', 'Disassembly');

Steps to Reproduce:

If you want to test that the label is not localized you can:

  1. follow the steps from Implement Disassembly View and InstructionBreakpoints #11186
  2. install a language pack through configure display language
  3. confirm that the label is only in english
@vince-fugnitto vince-fugnitto added beginners issues that are perfect for beginners good first issue good first issues for new contributors localization issues related to localization/internalization/nls disassembly issues related to the disassembly view labels Nov 29, 2022
@leon-arndt
Copy link
Contributor

I would like to try this as a first issue.

@vince-fugnitto
Copy link
Member Author

I would like to try this as a first issue.

@leon-arndt go ahead! Please don't hesitate to ask questions if you need any help.

leon-arndt added a commit to leon-arndt/theia that referenced this issue Nov 30, 2022
@leon-arndt
fix eclipse-theia#11932: add missing localization for disassembly-vie…
d5181fc 
…w title

Signed-off-by: Leon Arndt <neotalon27@gmail.com>
@leon-arndt leon-arndt mentioned this issue Nov 30, 2022
Merged
1 task
vince-fugnitto pushed a commit that referenced this issue Dec 2, 2022
@leon-arndt
fix #11932: add missing localization for disassembly-view title (#11939)
8f5e457 
Signed-off-by: Leon Arndt <neotalon27@gmail.com>

Signed-off-by: Leon Arndt <neotalon27@gmail.com>
This was referenced Feb 13, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginners issues that are perfect for beginners disassembly issues related to the disassembly view good first issue good first issues for new contributors localization issues related to localization/internalization/nls
Projects
None yet
Milestone
No milestone
2 participants
@leon-arndt @vince-fugnitto