Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #11932: add missing localization for disassembly-view title #11939

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

leon-arndt
Copy link
Contributor

@leon-arndt leon-arndt commented Nov 30, 2022

What it does

FIxed a simple missing localization key for the disassembly-view title.

How to test

Closes #11932:

Steps to Reproduce:
If you want to test that the label is not localized you can:

follow the steps from #11186
install a language pack through configure display language
confirm that the label is only in english

Review checklist

Reminder for reviewers

…w title

Signed-off-by: Leon Arndt <neotalon27@gmail.com>
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 👍

In order to accept your changes please be sure to sure to sign the eclipse contributor agreement (eca) with the same email as your authorship.

@leon-arndt
Copy link
Contributor Author

Thank you for the tip. I have tried common troubleshooting including https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/544 yet ECA still fails. Is there maybe some delay until it will succeed?
Name and e-mail seem to match.

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Nov 30, 2022

@leon-arndt I confirmed that the ECA is in fact properly signed for neotalon27@gmail.com.
I believe the CI check just needs some time to sync up and I'll re-validate it 👍

@vince-fugnitto vince-fugnitto added localization issues related to localization/internalization/nls disassembly issues related to the disassembly view labels Nov 30, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your first contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disassembly issues related to the disassembly view localization issues related to localization/internalization/nls
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debug: add missing localization for disassembly
2 participants