Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[builtins] [html] r.extensions.allAcrossExtensionHosts is not iterable #12276

Closed
marcdumais-work opened this issue Mar 9, 2023 · 0 comments · Fixed by #12277
Closed

[builtins] [html] r.extensions.allAcrossExtensionHosts is not iterable #12276

marcdumais-work opened this issue Mar 9, 2023 · 0 comments · Fixed by #12277
Labels
builtins Issues related to VS Code builtin extensions html Issues related to HTML functionality plug-in system issues related to the plug-in system

Comments

@marcdumais-work
Copy link
Contributor

marcdumais-work commented Mar 9, 2023 •
edited
Loading

Bug Description:

While testing vscode builtin extensions v1.70.2, I came across a problem with extension html-language-features not activating because of a missing (proposed_ API: allAcrossExtensionHosts :

2023-03-09T15:14:00.311Z root ERROR [hosted-plugin: 481163] Activating extension 'HTML Language Features (built-in)' failed: TypeError: r.extensions.allAcrossExtensionHosts is not iterable
    at o (/tmp/vscode-unpacked/html-language-features-1.70.2.vsix/extension/client/dist/node/htmlClientMain.js:1:695743)
    at t.getLanguageParticipants (/tmp/vscode-unpacked/html-language-features-1.70.2.vsix/extension/client/dist/node/htmlClientMain.js:1:695971)
    at t.startClient (/tmp/vscode-unpacked/html-language-features-1.70.2.vsix/extension/client/dist/node/htmlClientMain.js:1:694406)
    at e.activate (/tmp/vscode-unpacked/html-language-features-1.70.2.vsix/extension/client/dist/node/htmlClientMain.js:1:700580)
    at PluginManagerExtImpl.startPlugin (/home/lmcmcds/theia/packages/plugin-ext/lib/plugin/plugin-manager.js:308:81)

This API has been proposed for a while and still is used by this extension, as of the latest vscode release v1.76.0.

Here is where this API is referenced, in vscode v1.70.2:

vscode$ grep -R "allAcrossExtensionHosts" *
extensions/html-language-features/client/src/customData.ts: for (const extension of extensions.allAcrossExtensionHosts) {
extensions/html-language-features/client/src/languageParticipants.ts: for (const extension of extensions.allAcrossExtensionHosts) {
src/vscode-dts/vscode.proposed.extensionsAny.d.ts: export const allAcrossExtensionHosts: readonly Extension[];
src/vs/workbench/api/common/extHost.api.impl.ts: get allAcrossExtensionHosts(): vscode.Extension[] {

Steps to Reproduce:

  1. Start the example app using v1.70.2 of the vscode builtins (will be easier once they are published).
  2. Open a .html file to cause the extension to activate
  3. Look for the exception in the Theia backend's traces

Additional Information

  • Operating System:
  • Theia Version:
@marcdumais-work marcdumais-work added builtins Issues related to VS Code builtin extensions html Issues related to HTML functionality plug-in system issues related to the plug-in system labels Mar 9, 2023
marcdumais-work added a commit that referenced this issue Mar 9, 2023
@marcdumais-work
[plugin system] Add stubbed support for proposed extensions.allAcross…
0f3bc34 
…ExtensionHosts and related APIs

I believe that we do not support multiple extension hosts yet, so this
is effectively adding a stubbed version of these proposed vscode APIs,
for the benefit of extensions that use them.

At the moment, built-in "vscode.html-language-support" does, and will not activate
correctly without this.

Fixes #12276

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work added a commit that referenced this issue Mar 9, 2023
@marcdumais-work
[plugin system] Add stubbed support for proposed extensions.allAcross…
e15d8bf 
…ExtensionHosts and related APIs

I believe that we do not support multiple extension hosts yet, so this
is effectively adding a stubbed version of these proposed vscode APIs,
for the benefit of extensions that use them.

At the moment, built-in "vscode.html-language-support" (v.70.2) does,
and will not activate correctly without this.

Fixes #12276

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
@marcdumais-work marcdumais-work mentioned this issue Mar 9, 2023
Merged
3 tasks
marcdumais-work added a commit that referenced this issue Mar 9, 2023
@marcdumais-work
[plugin system] Add stubbed support for proposed extensions.allAcross…
a39be08 
…ExtensionHosts and related APIs

I believe that we do not support multiple extension hosts yet, so this
is effectively adding a stubbed version of these proposed vscode APIs,
for the benefit of extensions that use them.

At the moment, built-in "vscode.html-language-features" (1.70.2) does,
and will not activate correctly without this.

Fixes #12276

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work added a commit that referenced this issue Mar 10, 2023
@marcdumais-work
[plugin system] Add stubbed support for proposed extensions.allAcross…
4e40790 
…ExtensionHosts and related APIs

I believe that we do not support multiple extension hosts yet, so this
is effectively adding a stubbed version of these proposed vscode APIs,
for the benefit of extensions that use them.

At the moment, built-in "vscode.html-language-features" (1.70.2) does,
and will not activate correctly without this.

Fixes #12276

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
builtins Issues related to VS Code builtin extensions html Issues related to HTML functionality plug-in system issues related to the plug-in system
Projects
None yet
Milestone
No milestone
1 participant
@marcdumais-work