[plugin system] Add stubbed support for proposed extensions.allAcross ExtensionHosts and related APIs #12277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcdumais-work
added
plug-in system
…ExtensionHosts and related APIs I believe that we do not support multiple extension hosts yet, so this is effectively adding a stubbed version of these proposed vscode APIs, for the benefit of extensions that use them. At the moment, built-in "vscode.html-language-features" (1.70.2) does, and will not activate correctly without this. Fixes #12276 Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work
force-pushed
the
md/12276
branch
from
e15d8bf
to
a39be08
Compare
3 tasks
marcdumais-work
added a commit
that referenced
this pull request
Mar 10, 2023
Some time between 1.66.2 and 1.70.2, the references-view extension "ms-vscode.references-view" has gone from a standalone extension, that has its own repository, to a vscode built-in extension, that's part of the vscode repository. With that change, the extension's publisher has been updated from "ms-vscode" to "vscode". As of 1.70.2, this extension is referenced in the builtins extension pack and no longer needs to be specifically referenced in `package.json`. This PR contains the following: Example application: - update the builtin extension pack to v1.70.2 - remove entry for old `references-view` extension - remove pinning for typescript extensions. - pin html-language-features to 1.66.2, since v1.70.2 will not work until PR #12277 is merged typescript browser tests: - use new publisher when referencing `references-view` builtin Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
vince-fugnitto
approved these changes
Mar 10, 2023
marcdumais-work
removed
the
CQ Required (deprecated)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
I believe that we do not support multiple extension hosts yet, so this is effectively adding a stubbed version of these proposed vscode APIs, for the benefit of extensions that use them.
At the moment, built-in "vscode.html-language-features" (v1.70.2) does, and will not activate correctly without this.
Fixes #12276
How to test
Here's the extension that I built locally (it's not published yet):
html-language-features-1.70.2.zip
plugins. Remove foldervscode.html-language-featuresif it exists..htmlfileconfirm that the CQ for the copied content is approved[1][1 ] : no IP check necessary in this case. See: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/7350#note_1090755
Review checklist
Reminder for reviewers