-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vscode extension LaTeX Workshop's Viewer does not open in Theia IDE in browser #13522
Comments
@dannaf Could you quickly retest this with the latest Theia IDE desktop version? https://theia-ide.org/#theiaide |
Same issue, essentially: the extension's Viewer did not open for me upon clicking the View LaTex PDF file button at the top-right of the Editor. However, when trying all the four command palette actions that the extension provides, the |
Actually the The main bug that this issue represents is still open, however, because the main in-Theia Viewer that the extension implements is not working, neither in Theia IDE via the browser or via the desktop application. |
look chrome console after click 'view in tab' |
@dannaf Opening a pdf file in the latex workshop viewer works for me in 1.48.0. Please comment if you still have an issue. |
FYI, preview is available here: https://download.eclipse.org/theia/ide-preview/1.48.0/ |
1.48.2 not works for me, chrome console show: maximum call stack exceeded error. |
@yuhorun obviously, we're doing something differently, because opening a pdf file works for me. Can you give exact steps what you are doing so we can figure it out? |
Thank you for your attention and contribution, my operation is as follows:
I recorded a video reproducing the error. os: ubuntu22.04 issue.mp4 |
@yuhorun can you open a pdf file from the navigator view if you already have it in the workspace? Btw: the video file does not play for me on Windows 11. |
@tsmaeder I re-uploaded the video to recreate the problem, and if you still can't open it, please play it on google Cloud Drive: issue.webm |
@tsmaeder Please reopen this. I'm experiencing the same issue in 1.49.1 and 1.50.0 preview. Error message is: |
@yuhorun I'm not familiar with latex. What setup is needed (I'm on Windows) and how do I "compile"? |
@tsmaeder The LaTeX Workshop Requirements section lists TeX Live as recommended among possible alternative LaTeX distributions. I have tested with TeX Live Full (comes at ~8gb install size and took >1h to install) on Windows 11 which (for reference) plays nicely with LaTeX Workshop in VSCode (1.90.0). I believe this issue is independent of the choice of latex distribution, though. The LaTeX Workshop comes with a Build LaTeX project button (play icon, see also @yuhorun's video) for automagic compilation. |
Bumped. Encountered same issue with Theia IDE ver. 1.52.0 |
I believe this is a programming error in the LaTex Workshop extensions. Turns out the extension invokes
Invoking the function in this way, the Note that the corresponding VS Code implementation was done in microsoft/vscode#115530, with the purpose of hiding the main-side proxies from the API consumers and the side effect of the |
@tsmaeder I see. I would also think of the vscode API methods as functions that don't require a A refactoring to support this use case would be appropriate. |
Namespaces have functions, but objects have methods. The VS Code doc explicitly distinguishes between the two 🤷 |
The thing is, we'd have to refactor every interface instance we return and every class defined in the VS Code API. Not sure that's worth it for enabling what is basically a programming error. |
I wanted to file an issue in LaTeX Workshop repo, but unfortunately Theia is not officially supported. |
@tsmaeder I'd argue that the
If you want to use |
@msujew invoking an object method as a pure function is a programming error. The equivalent in your example would be this:
That might or might not work. |
They might still want to know about this. "Does not support" does not mean they are actively trying to be incompatible. |
A cursory inspection has identified at least 16 classes we'd have to adapt. |
Another problem is that if we rewrite the api objects we would have to make sure we convert them properly when sending stuff over the ext/main interface. The VS Code style is that they create a proxy object that has only getters/setters referring to some "original" object. Sending such an object will typically send an object without any properties. |
LaTeX Workshop ver. 10.4.0 seems have fixed the issue opening the PDF in another tab (of TheiaIDE desktop) and web browser. |
Bug Description:
The LaTeX Workshop vscode extension's Viewer does not work on Theia IDE in the browser.
(I considered opening this as a Discussion but decided on an Issue/Bug because this involves a vscode extension working in vscode but specifically not working on Theia. I downloaded the extension on vscode locally and the extension's Viewer did open, so it seems that the problem has to do with Theia. Moreover, while the LaTeX Workshop vscode extension does not officially support Eclipse Theia, Theia does aim to support vscode extensions. So I can still expect that this extension should fully work on Theia, including on Theia IDE — correct?)
Steps to Reproduce:
Additional Information
This question is related to #7988, but that discussion was never answered (and in any case seems outdated, perhaps even dating to before Theia implemented vscode extensions at runtime?), so I would like to restart this discussion. Moreover, that is not the exact issue that I have. For me the LaTeX Workshop's Viewer is not even opening.
System Information
The text was updated successfully, but these errors were encountered: