Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot go to next/prev tab with default key (Ctrl+tab) in browser #1891

Closed
MarkZ3 opened this issue May 11, 2018 · 1 comment
Closed

Cannot go to next/prev tab with default key (Ctrl+tab) in browser #1891

MarkZ3 opened this issue May 11, 2018 · 1 comment
Labels
keybindings issues related to keybindings

Comments

@MarkZ3
Copy link
Contributor

MarkZ3 commented May 11, 2018

The default key bindings for going to next/prev tab are respectively Ctrl+tab and Ctrl+shift+tab. But in the browser, this switches the browser tabs, not Theia tabs. The default key binding should be changed to something more sensible.
@kittaakos kittaakos added the keybindings issues related to keybindings label May 12, 2018
@MarkZ3 MarkZ3 mentioned this issue May 14, 2018
Closed
@vince-fugnitto vince-fugnitto mentioned this issue Nov 2, 2018
Merged
paul-marechal added a commit that referenced this issue Nov 5, 2018
@paul-marechal
[core] Add shortcuts for browser tab switch
2861bc6 
Before, it was set to just `ctrl+tab`, but this doesn't work in browsers.
Add `ctrl+alt+a` and `ctrl+alt+d` in order to switch between tabs.

Fix #492 #1891

Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
paul-marechal added a commit that referenced this issue Nov 5, 2018
@paul-marechal
[core] Add shortcuts for browser tab switch
0addbb5 
Before, it was set to just `ctrl+tab`, but this doesn't work in browsers.
Add `ctrl+alt+a` and `ctrl+alt+d` in order to switch between tabs.

Fix #492 #1891

Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
paul-marechal added a commit that referenced this issue Nov 8, 2018
@paul-marechal
[core] Add shortcuts for browser tab switch
cd7a51a 
Before, it was set to just `ctrl+tab`, but this doesn't work in browsers.
Add `ctrl+alt+a` and `ctrl+alt+d` in order to switch between tabs.

Fix #492 #1891

Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
paul-marechal added a commit that referenced this issue Nov 8, 2018
@paul-marechal
[core] Add shortcuts for browser tab switch
0e7d74c 
Before, it was set to just `ctrl+tab`, but this doesn't work in browsers.
Add `ctrl+alt+a` and `ctrl+alt+d` in order to switch between tabs.

Fix #492 #1891

Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
paul-marechal added a commit that referenced this issue Nov 9, 2018
@paul-marechal
[core] Add shortcuts for browser tab switch
bc233dd 
Before, it was set to just `ctrl+tab`, but this doesn't work in browsers.
Add `ctrl+alt+a` and `ctrl+alt+d` in order to switch between tabs.

Fix #492 #1891

Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
paul-marechal added a commit that referenced this issue Nov 12, 2018
@paul-marechal
[core] Add shortcuts for browser tab switch
76911ee 
Before, it was set to just `ctrl+tab`, but this doesn't work in browsers.
Add `ctrl+alt+a` and `ctrl+alt+d` in order to switch between tabs.

Fix #492 #1891

Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
@vince-fugnitto vince-fugnitto mentioned this issue Nov 13, 2018
Closed
@vince-fugnitto
Copy link
Member

closed thanks to #3381

bogthe pushed a commit to ARMmbed/theia that referenced this issue Jan 21, 2019
@paul-marechal
[core] Add shortcuts for browser tab switch
0cab934 
Before, it was set to just `ctrl+tab`, but this doesn't work in browsers.
Add `ctrl+alt+a` and `ctrl+alt+d` in order to switch between tabs.

Fix eclipse-theia#492 eclipse-theia#1891

Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
Signed-off-by: Bogdan Stolojan <petre.stolojan@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
keybindings issues related to keybindings
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MarkZ3 @kittaakos @vince-fugnitto