Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to next tab or previous tab keybinding does not work in the browser example #492

Closed
hexa00 opened this issue Sep 11, 2017 · 3 comments
Closed

Switch to next tab or previous tab keybinding does not work in the browser example #492

hexa00 opened this issue Sep 11, 2017 · 3 comments

Comments

@hexa00
Copy link

hexa00 commented Sep 11, 2017

Doing Ctrl-Esc or Ctrl-Shift-Esc doesn't do anything...

Using Chrome.

Also I think this keybinding is not practical at all ? Where does it come from ?
@hexa00
Copy link
Author

hexa00 commented Sep 18, 2017

The keybindings were wrong because of #493

But even with this now fixed, The keybinding Ctrl-Tab and Ctrl-Shift-Tab doesn't work in the browser Example on Chrome.

Selecting the action in the palette works however.

@hexa00
Copy link
Author

hexa00 commented Sep 18, 2017

This is conflicting with the browser's keybindings and so the browsers tabs switch rather than Theia's

@spoenemann
Copy link
Contributor

On Mac OS the current keybinding is Cmd-Tab / Cmd-Shift-Tab. That is even worse because it conflicts with the OS keybinding for switching apps. We should change those keybindings.

VS Code uses ctrlcmd+alt+arrowleft and ctrlcmd+alt+arrowright.

@vince-fugnitto vince-fugnitto mentioned this issue Nov 2, 2018
Merged
paul-marechal added a commit that referenced this issue Nov 5, 2018
@paul-marechal
[core] Add shortcuts for browser tab switch
2861bc6 
Before, it was set to just `ctrl+tab`, but this doesn't work in browsers.
Add `ctrl+alt+a` and `ctrl+alt+d` in order to switch between tabs.

Fix #492 #1891

Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
paul-marechal added a commit that referenced this issue Nov 5, 2018
@paul-marechal
[core] Add shortcuts for browser tab switch
0addbb5 
Before, it was set to just `ctrl+tab`, but this doesn't work in browsers.
Add `ctrl+alt+a` and `ctrl+alt+d` in order to switch between tabs.

Fix #492 #1891

Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
paul-marechal added a commit that referenced this issue Nov 8, 2018
@paul-marechal
[core] Add shortcuts for browser tab switch
cd7a51a 
Before, it was set to just `ctrl+tab`, but this doesn't work in browsers.
Add `ctrl+alt+a` and `ctrl+alt+d` in order to switch between tabs.

Fix #492 #1891

Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
paul-marechal added a commit that referenced this issue Nov 8, 2018
@paul-marechal
[core] Add shortcuts for browser tab switch
0e7d74c 
Before, it was set to just `ctrl+tab`, but this doesn't work in browsers.
Add `ctrl+alt+a` and `ctrl+alt+d` in order to switch between tabs.

Fix #492 #1891

Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
paul-marechal added a commit that referenced this issue Nov 12, 2018
@paul-marechal
[core] Add shortcuts for browser tab switch
76911ee 
Before, it was set to just `ctrl+tab`, but this doesn't work in browsers.
Add `ctrl+alt+a` and `ctrl+alt+d` in order to switch between tabs.

Fix #492 #1891

Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
@vince-fugnitto vince-fugnitto mentioned this issue Nov 13, 2018
Closed
bogthe pushed a commit to ARMmbed/theia that referenced this issue Jan 21, 2019
@paul-marechal
[core] Add shortcuts for browser tab switch
0cab934 
Before, it was set to just `ctrl+tab`, but this doesn't work in browsers.
Add `ctrl+alt+a` and `ctrl+alt+d` in order to switch between tabs.

Fix eclipse-theia#492 eclipse-theia#1891

Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
Signed-off-by: Bogdan Stolojan <petre.stolojan@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hexa00 @spoenemann