Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

active debug session is not properly updated #4176

Closed
akosyakov opened this issue Jan 28, 2019 · 2 comments · Fixed by #4177
Closed

active debug session is not properly updated #4176

akosyakov opened this issue Jan 28, 2019 · 2 comments · Fixed by #4177
Assignees
Labels
bug bugs found in the application debug issues that related to debug functionality plug-in system issues related to the plug-in system

Comments

@akosyakov
Copy link
Member

Toggle skipping this file command from node-debug extension does not work because of it https://code.visualstudio.com/docs/nodejs/nodejs-debugging#_skipping-uninteresting-code-node-chrome

@akosyakov akosyakov added bug bugs found in the application plug-in system issues related to the plug-in system debug issues that related to debug functionality labels Jan 28, 2019
@akosyakov akosyakov self-assigned this Jan 28, 2019
@akosyakov
Copy link
Member Author

Also custom request is sent with bogus arguments with command id as a session id:

root ERROR [hosted-plugin: 589] (node:589) UnhandledPromiseRejectionWarning: Error: Debug session 'toggleSkipFileStatus' not found
    at DebugMainImpl.<anonymous> (https://3030-ba36598e-e862-400e-8c56-7c198d488fa4.ws-us.gitpod.io/55.bundle.js:5270:23)
    at step (https://3030-ba36598e-e862-400e-8c56-7c198d488fa4.ws-us.gitpod.io/55.bundle.js:5064:23)
    at Object.next (https://3030-ba36598e-e862-400e-8c56-7c198d488fa4.ws-us.gitpod.io/55.bundle.js:5045:53)
    at https://3030-ba36598e-e862-400e-8c56-7c198d488fa4.ws-us.gitpod.io/55.bundle.js:5039:71
    at new Promise (<anonymous>)
    at push.../../packages/plugin-ext/lib/main/browser/debug/debug-main.js.__awaiter (https://3030-ba36598e-e862-400e-8c56-7c198d488fa4.ws-us.gitpod.io/55.bundle.js:5035:12)
    at DebugMainImpl.push.../../packages/plugin-ext/lib/main/browser/debug/debug-main.js.DebugMainImpl.$customRequest (https://3030-ba36598e-e862-400e-8c56-7c198d488fa4.ws-us.gitpod.io/55.bundle.js:5263:16)
    at RPCProtocolImpl.push.../../packages/plugin-ext/lib/api/rpc-protocol.js.RPCProtocolImpl.doInvokeHandler (https://3030-ba36598e-e862-400e-8c56-7c198d488fa4.ws-us.gitpod.io/55.bundle.js:827:23)
    at RPCProtocolImpl.push.../../packages/plugin-ext/lib/api/rpc-protocol.js.RPCProtocolImpl.invokeHandler (https://3030-ba36598e-e862-400e-8c56-7c198d488fa4.ws-us.gitpod.io/55.bundle.js:812:41)
    at RPCProtocolImpl.push.../../packages/plugin-ext/lib/api/rpc-protocol.js.RPCProtocolImpl.receiveRequest (https://3030-ba36598e-e862-400e-8c56-7c198d488fa4.ws-us.gitpod.io/55.bundle.js:776:45)

@akosyakov
Copy link
Member Author

Also threads' calls stack should be updated on stopped, otherwise UI shows outdated state, for example that call stack is enabled, when it was skipped.

akosyakov added a commit that referenced this issue Jan 28, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jan 28, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jan 30, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application debug issues that related to debug functionality plug-in system issues related to the plug-in system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant