[node-debug] fixes for Toggle skipping this file command
#4177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
benoitf
reviewed
Jan 28, 2019
| @@ -977,7 +977,7 @@ export interface DebugMain { | |||
| $addBreakpoints(breakpoints: Breakpoint[]): Promise<void>; | |||
| $removeBreakpoints(breakpoints: Breakpoint[]): Promise<void>; | |||
| $startDebugging(folder: theia.WorkspaceFolder | undefined, nameOrConfiguration: string | theia.DebugConfiguration): Promise<boolean>; | |||
| $customRequest(command: string, args?: any): Promise<DebugProtocol.Response>; | |||
| $customRequest(sessionId: string, command: string, args?: any): Promise<DebugProtocol.Response>; | |||
There was a problem hiding this comment.
shouldn't we add new method or add argument at the end to not break ?
There was a problem hiding this comment.
hmm is that in fact there were a problem, command was being sent instead of sessionId ?
There was a problem hiding this comment.
i thought it was a mistake in the first place, implementation has different method signature and was broken before by using command as sessionId:
https://github.com/theia-ide/theia/blob/438efefd9b90e53aa58f54f2a8dfd50af8ba045b/packages/plugin-ext/src/main/browser/debug/debug-main.ts#L196
benoitf
approved these changes
Jan 28, 2019
tolusha
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4176
It depends on #4173, otherwise there is no a menu item.