[vscode] support activation events

[dehru]

Hello, I've got a vscode extension running in theia version "next" ( "version": "0.4.0-next.e2f3ec66" ). But there's a slight difference in when the activation() lifecycle method gets called.

The vscode extension was built with "vscode": "1.1.28", and has this info in it's package.json

        "activationEvents": [
		"onCommand:extension.execute-command"
	],
	"main": "./out/extension.js",
	"contributes": {
		"commands": [{
			"command": "extension.execute-command",
			"title": "Hello Execute Command"
		}]
	},

And a very simple extension.ts that looks like this.

import * as vscode from 'vscode';

export function activate(context: vscode.ExtensionContext) {
	console.log('activate called');
	vscode.commands.executeCommand('setContext', 'thisContext', true);
}

export function deactivate() {}

When running in vscode, the activate method is not called until the command is actually triggered through the vscode command palette.

When running inside theia, the activate method is called as soon as the browser is connected / opened. This makes debugging the activate method a little more challenging. And could lead to different behavior with vscode extensions.

[akosyakov]

Activation events are not supported yet, VS Code extensions are activated eagerly for now.

[akosyakov]

Hit it again trying to debug LS process of vetur VS Code extension. It's really hard since debug configuration rely on lazy loading of extensions :(

[akosyakov]

For rust extension, it is necessary to fix it, otherwise it starts contributing UI elements regardless whether rust project opened or not.

[akosyakov]

• workspaceContains https://github.com/microsoft/vscode/blob/893bf4ea1f8c158125746c3fe959ef4e23883282/src/vs/workbench/api/node/extHostExtensionService.ts#L442
• onWebviewPanel requires [webview] WebviewPanelSerializer are registered but never used #5647
  https://github.com/microsoft/vscode/blob/893bf4ea1f8c158125746c3fe959ef4e23883282/src/vs/workbench/api/browser/mainThreadWebview.ts#L72
• onView https://github.com/microsoft/vscode/blob/893bf4ea1f8c158125746c3fe959ef4e23883282/src/vs/workbench/browser/parts/views/customView.ts#L499
• onDebug, onDebugAdapterProtocolTracker, onDebugResolve, onDebugInitialConfigurations https://github.com/microsoft/vscode/blob/893bf4ea1f8c158125746c3fe959ef4e23883282/src/vs/workbench/contrib/debug/browser/debugConfigurationManager.ts#L434 and https://github.com/microsoft/vscode/blob/893bf4ea1f8c158125746c3fe959ef4e23883282/src/vs/workbench/contrib/debug/browser/debugService.ts#L257
• onCommand:workbench.action.tasks.runTask see also some plugins are not loaded in time #5861 covered in ensure that plugin tasks are registered before accessing them #5869
  https://github.com/microsoft/vscode/blob/893bf4ea1f8c158125746c3fe959ef4e23883282/src/vs/workbench/contrib/tasks/browser/taskQuickOpen.ts#L43 and https://github.com/microsoft/vscode/blob/893bf4ea1f8c158125746c3fe959ef4e23883282/src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts#L1112
• * - after initial contributions are initialized
  https://github.com/microsoft/vscode/blob/893bf4ea1f8c158125746c3fe959ef4e23883282/src/vs/workbench/services/commands/common/commandService.ts#L39
• onCommand
  https://github.com/microsoft/vscode/blob/893bf4ea1f8c158125746c3fe959ef4e23883282/src/vs/workbench/services/commands/common/commandService.ts#L53
• onFileSystem
  https://github.com/microsoft/vscode/blob/893bf4ea1f8c158125746c3fe959ef4e23883282/src/vs/workbench/services/extensions/common/abstractExtensionService.ts#L78
• onUri
  https://github.com/microsoft/vscode/blob/893bf4ea1f8c158125746c3fe959ef4e23883282/src/vs/workbench/services/extensions/common/inactiveExtensionUrlHandler.ts#L136
• onLanguage
  https://github.com/microsoft/vscode/blob/893bf4ea1f8c158125746c3fe959ef4e23883282/src/vs/workbench/services/mode/common/workbenchModeService.ts#L155
• onSearch
  https://github.com/microsoft/vscode/blob/893bf4ea1f8c158125746c3fe959ef4e23883282/src/vs/workbench/services/search/common/searchService.ts#L98
• for forward compatibility fallback to * and report unknown activation event as an error to the console
• onAuthenticationRequest: https://github.com/microsoft/vscode/blob/0a22f70e66bee825459d1f25539395094be0b6bc/src/vs/workbench/services/authentication/browser/authenticationService.ts#L20
• onCustomEditor:
  https://github.com/microsoft/vscode/blob/0a22f70e66bee825459d1f25539395094be0b6bc/src/vs/workbench/api/browser/mainThreadWebview.ts#L162
• onNotebook:
  https://github.com/microsoft/vscode/blob/0a22f70e66bee825459d1f25539395094be0b6bc/src/vs/workbench/contrib/notebook/browser/notebookServiceImpl.ts#L540
• 'onTaskType'
• 'onRenderer'
• 'onWalkthrough'
• 'onOpenExternalUri'
• 'onEditSession'
• 'onTerminalQuickFixRequest'

[akosyakov]

Docs:

• https://code.visualstudio.com/api/references/activation-events
• onDebugAdapterProtocolTracker in https://code.visualstudio.com/updates/v1_30

[akosyakov]

For onView event we need to integrate new view containers in the plugin system first, since it should be fired on expansion on the view. If we do it now we need to reimplement it later again.

[akosyakov]

I will stop working on it. onView and onWebview require substantial refactoring in the plugin system to integrate them properly with the shell. Regarding the rest of events i have not seen them in practice used a lot and will wait for some extension to come around.

[akosyakov]

onView is covered in #5665

[akosyakov]

onWebviewPanel is covered in #6465

[akosyakov]

onFileSystem is covered in #7908

[tsmaeder]

Closing this omnibus issue, as we generally support activation events.

[alvsan09]

@tsmaeder,
We are missing the support of multiple activation events as reflected under the following comment:
#4199 (comment)

How can we track those?
A newer issue, perhaps ?

[tsmaeder]

The list is at least partially out of date ("onRenderer"). If we have missing activation events, they should be tracked by separate issues and linked to the VS Code API version where they appear. This old issue is not useful, IMO.

[alvsan09]

The list is at least partially out of date ("onRenderer"). If we have missing activation events, they should be tracked by separate issues and linked to the VS Code API version where they appear. This old issue is not useful, IMO.

@tsmaeder , Unfortunately the activation events are independent of the vscode API, and would therefore need a parallel tracking,
I think we need parallel tacking of the following vscode interfaces.

1. vscode API, (already tracked)
2. vscode Proposed APIs (Discussion @ VS Code API support: proposed APIs #12450)
3. vscode Activation Events
4. vscode Contribution points