view containers integration

[akosyakov]

New container contributed by the plugin system:

Views contributed to the explorer container by the plugin system:

What it does

• close [shell] view containers and tabs #5058 - complete integration of view containers in the plugin system and shell
• [vscode] support activation events #4199 - support onView activation event
• register views after all view containers are registered
• fix support view title menu contributions #4174 - support view/title menu contribution
• support more view/title menu contribution
• pre-defined views
  • debug
  • scm
  • explorer
  • test
    • a CQ for copied icon - https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20431
• a command to toggle view container in the view menu and the command palette
• commands to toggle view containers contributed by plugin system
• Open View command
• quick open view prefix
• implemented TreeItem2.label proposed API for sample extension
  3ea5c9ddbebd8ec68e3b821f9c39c3ec785fde97/src/vs/vscode.proposed.d.ts#L1436-L1477
  • a CQ for copied code - https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20431
• fix Align vscode views contents with header file #4637 - single-view view-container mode
  • view caption should be inlined into the view container caption
  • view toolbar items should be inlined into the view container toolbar
    • scm
    • explorer
    • plugin views
  • toolbar context menu should allow to hide/show view parts
• show view container part's toolbar only on hover
• plugin tree views: not enough space between icon and text if the width is small
• restoration layout of view container on reload
  • debug - no stateful
  • scm - input message is preserved
  • explorer
    • fix [layout restoration][navigator] widget state restored, immediately reset #1781 - restore internal state of the navigator
  • test
  • plugin views
    • remove stale widget, i.e. which are not registered anymore
    • move widgets to new view containers if package.json was changed
    • restore internal state of plugin tree widgets
• view container activation
  • should restore active part on restore of shell layout
  • should restore previous active part on activation, or activate the first expanded or visible part, or receive focus itself
• shell: handle activation and reveal requests recursively
• fix UI tests
• shell layout versioning and backward-compatibility
• integrate remove one colon from double colons in the code #5718

How to test

• install https://github.com/microsoft/vscode-extension-samples/tree/master/tree-view-sample from sources under `plugins folder
• run Theia and check that all views are added
• modify package.json to move views to other view containers (scm, debug, test) and test that views are added there as well

What to pay attention:

• keyboard navigation: one can navigate between view parts with keyboard plus collapse and expand them, try to drag and drop as well
• activation (focus): a proper part is focused
• restoration of layout
• explorer in multi-root workspace

Review checklist

• as an author, I have thoroughly tested my changes and carefully reviewed following the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[akosyakov]

@tetchel @ariel-bentu could you give it a try with your extensions contributing view containers and views? Feedback is very welcomed!

[tetchel]

It does not appear to have worked for me.

        "views": {
            "explorer": [
                {
                    "id": "%viewID%",
                    "name": "%viewName%"
                }
            ]
        },

where:

    "viewName": "Codewind",
    "viewID": "ext.cw.explorer",

this is the same snippet that works in VS Code.

VS Code:

Theia:

Note the Explorer icon broke, and there is still just the one main view.

[akosyakov]

@tetchel why do you use internalization for internal constants? it should be used for user visible text. Anyway i will add handling for it, since it appears to happen :)

It would be good if you direct me how i can get the same results, i.e. which extension to try with which project.

[akosyakov]

@tetchel Could you also try to do Reset Workbench Layout? Since layout changed so much old layout data probably cannot be loaded.

@svenefftinge @spoenemann @kittaakos I'm thinking to add a
layout version to layout data, so we increase it each time to reject old layout state. It would allow to make backward incompatible changes to the layout without breaking clients.

[tetchel]

I suppose it's true that there's no point in externalizing the viewID. let me see if that fixes it.

[kittaakos]

I'm thinking to add a
layout version to layout data

I had a deja vu after reading your comment, @akosyakov 😊 We already have something for it:
https://github.com/theia-ide/theia/blob/613069fc87169738999adab4044bc0530e54cb74/packages/core/src/browser/shell/application-shell.ts#L48

The related task was: #1075
PR: #1603

[akosyakov]

@kittaakos oh, cool, i can just increase it!

[akosyakov]

@tetchel could you pull and try again, I've increased layout data version, so it should be loaded from scratch for you now

[tetchel]

After changing the viewID and pulling, it worked! 🎉

[akosyakov]

@tetchel cool! I've noticed that tree elements look different for you. Could you please file issues for such UI differences as well?

[tetchel]

Do you mean the differences in text on the Projects and No Projects item? That's by design in my code.
or is there some other difference?

[akosyakov]

@tetchel there is for example Click here to create... in VS Code, but not in Theia

[tetchel]

Yea that is intentional because in vs code clicking that item runs the Create Project command. But I removed it in theia because on-click tree item commands don't work. Similarly in VS Code Projects (Local) is correct but in my Theia case it is confusing to a user ("local" doesn't really apply) so I removed it.

There are some intentional differences, which is why I opened #5501

Bottom line is, my tree works great with this change.

[akosyakov]

ok, do we have an issue already for But I removed it in theia because on-click tree item commands don't work. @tetchel ?

[tetchel]

I thought we did, but it was just a few comments on #5661. I just opened #5744, thanks for the bump.

[akosyakov]

@AlexTugarev triy again, I've messed up rebase last time

[AlexTugarev]

Verified, the most recent change does solve the issue with moved views. Cool!

[akosyakov]

I'm merging if noone objects when the build is green. Please open new issues if something breaks afterwards. It will be my top-priority to fix them.