Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scm] remove hover background on scm inline actions #6075

Closed
vince-fugnitto opened this issue Aug 30, 2019 · 1 comment · Fixed by #6094
Closed

[scm] remove hover background on scm inline actions #6075

vince-fugnitto opened this issue Aug 30, 2019 · 1 comment · Fixed by #6094
Labels
good first issue good first issues for new contributors help wanted issues meant to be picked up, require help ui/ux issues related to user interface / user experience

Comments

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Aug 30, 2019 •
edited
Loading

Description

Remove the hover background on the scm inline actions so it's consistent with other
views (ex: search-in-workspace), and with VSCode.

The hover background gives off a bad UI especially on light themes.

How to test:

  1. open a workspace under git source control (ex: 'theia')
  2. update the color theme to the light theme (File > Settings > Change Color Theme)
  3. perform some changes on a file
  4. open the scm widget (View > SCM)
  5. highlight over the change and highlight the buttons

Example: (highlighting over the stage changes button)

Screen Shot 2019-08-30 at 1 47 49 PM

cc @akosyakov do we want to align and simply remove the highlighting over the buttons like VSCode and other views?
@vince-fugnitto vince-fugnitto added help wanted issues meant to be picked up, require help good first issue good first issues for new contributors ui/ux issues related to user interface / user experience labels Aug 30, 2019
@akosyakov
Copy link
Member

@vince-fugnitto do as you think it is better

@vince-fugnitto vince-fugnitto changed the title [scm] update highlight color on light-theme [scm] remove hover background on scm inline actions Sep 3, 2019
vince-fugnitto added a commit that referenced this issue Sep 3, 2019
@vince-fugnitto
Remove hover background on the scm inline actions
a93b42f 
Fixes #6075

Remove the hover background over the `scm` inline actions
so that it is consistent with other views (ex: `search-in-workspace`),
toolbar items, and is aligned with VSCode.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto mentioned this issue Sep 3, 2019
Merged
1 task
vince-fugnitto added a commit that referenced this issue Sep 4, 2019
@vince-fugnitto
Remove hover background on the scm inline actions
e55e339 
Fixes #6075

Remove the hover background over the `scm` inline actions
so that it is consistent with other views (ex: `search-in-workspace`),
toolbar items, and is aligned with VSCode.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue good first issues for new contributors help wanted issues meant to be picked up, require help ui/ux issues related to user interface / user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove hover background on the scm inline actions eclipse-theia/theia
2 participants
@akosyakov @vince-fugnitto