Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hover background on the scm inline actions #6094

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes #6075

Remove the hover background over the scm inline actions
so that it is consistent with other views (ex: search-in-workspace),
toolbar items, and is aligned with VSCode.

Peek 2019-09-03 07-10

How to test

  1. open a workspace under git source control (ex: theia)
  2. make some temporary changes on a file
  3. open the scm view (View > SCM)
  4. highlight over the change, there should not be a hover background anymore

Review checklist

Reminder for reviewers

Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com

Fixes #6075

Remove the hover background over the `scm` inline actions
so that it is consistent with other views (ex: `search-in-workspace`),
toolbar items, and is aligned with VSCode.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added ui/ux issues related to user interface / user experience scm issues related to the source control manager labels Sep 3, 2019
@vince-fugnitto vince-fugnitto self-assigned this Sep 3, 2019
Copy link
Contributor

@lmcbout lmcbout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Test:Ok

@vince-fugnitto
Copy link
Member Author

Thanks for the review @lmcbout :)

@vince-fugnitto vince-fugnitto merged commit e55e339 into master Sep 4, 2019
@vince-fugnitto vince-fugnitto deleted the vf/GH-6075 branch September 4, 2019 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scm issues related to the source control manager ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[scm] remove hover background on scm inline actions
2 participants