Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug adapters cannot be fetched #6111

Closed
AlexTugarev opened this issue Sep 5, 2019 · 10 comments
Closed

Debug adapters cannot be fetched #6111

AlexTugarev opened this issue Sep 5, 2019 · 10 comments
Assignees
Labels
debug issues that related to debug functionality vscode issues related to VSCode compatibility

Comments

@AlexTugarev
Copy link
Contributor

cf. #6110 (comment)

builds are broken because debug adapter cannot be fetched.

@theia/java-debug and @theia/debug-nodejs are affected.
one option is to get rid of them at all and use the vscode extension instead.

@akosyakov
Copy link
Member

What do we do with theia apps fetching va code extensions? Like go?

What downstream native debug extensions do? Like debugging for cpp?

@svenefftinge
Copy link
Contributor

Can we solve those issues where they happen? Generally we should not rely on downloading extensions from the marketplace, so I'd say it's best for those downstream builds to have the required bits checked in or hosted elsewhere.
For this repository, however, it seems like we could get rid of that code alltogether.

@akosyakov
Copy link
Member

For time being can we just exclude them from yarn workspaces?

@svenefftinge
Copy link
Contributor

ok, will do

@svenefftinge svenefftinge self-assigned this Sep 5, 2019
@akosyakov
Copy link
Member

Ok, I’m fine with removing them.

@akosyakov
Copy link
Member

Can we solve those issues where they happen?

I don’t think it is possible because our download script does not allow to set something like auth token for marketplace

svenefftinge added a commit that referenced this issue Sep 5, 2019
Fixes #6111

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
@marcdumais-work
Copy link
Contributor

I don’t think it is possible because our download script does not allow to set something like auth token for marketplace

I think anyway that it's against the marketplace license/user agreement to use it from a non-Microsoft product.

When individual license permits I think we are allowed to make the extensions available from an alternate place, like a GH release. So we could for now add them to one of our repos and download from there. Maybe we can create a new repo, theia-ide/vscode-extensions or such for this?

At least until we have our own public registry.

@akosyakov
Copy link
Member

When individual license permits I think we are allowed to make the extensions available from an alternate place, like a GH release. So we could for now add them to one of our repos and download from there. Maybe we can create a new repo, theia-ide/vscode-extensions or such for this?

GitHub is not the best place. They have limited access rate as well. Maybe on some free CDN.

At least until we have our own public registry.

Having our public registry will be the best.

@marcdumais-work
Copy link
Contributor

GitHub is not the best place. They have limited access rate as well.

True. If we add GH downloads pass a certain point, it will probably fail even with GH Token. But until we reach that point, it should be ok?

Maybe on some free CDN.

Could be ok but harder to manage access rights for everyone who might need to update the extensions there.

@akosyakov
Copy link
Member

True. If we add GH downloads pass a certain point, it will probably fail even with GH Token. But until we reach that point, it should be ok?

ok, true, we pass GH token for rigrep everywhere, so probably everybody do the same already

marcdumais-work added a commit that referenced this issue Sep 5, 2019
This patch downloads the Java debug adapter from
the component's GH releases and node-debug /
node-debug2 from our fork of these components,
since the .vsix files are not available from
upstream repos releases.

Fixes #6111

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
@akosyakov akosyakov added debug issues that related to debug functionality vscode issues related to VSCode compatibility labels Sep 6, 2019
svenefftinge added a commit that referenced this issue Sep 6, 2019
Fixes #6111

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
svenefftinge added a commit that referenced this issue Sep 6, 2019
Fixes #6111

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants