-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug adapters cannot be fetched #6111
Comments
What do we do with theia apps fetching va code extensions? Like go? What downstream native debug extensions do? Like debugging for cpp? |
Can we solve those issues where they happen? Generally we should not rely on downloading extensions from the marketplace, so I'd say it's best for those downstream builds to have the required bits checked in or hosted elsewhere. |
For time being can we just exclude them from yarn workspaces? |
ok, will do |
Ok, I’m fine with removing them. |
I don’t think it is possible because our download script does not allow to set something like auth token for marketplace |
Fixes #6111 Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
I think anyway that it's against the marketplace license/user agreement to use it from a non-Microsoft product. When individual license permits I think we are allowed to make the extensions available from an alternate place, like a GH release. So we could for now add them to one of our repos and download from there. Maybe we can create a new repo, At least until we have our own public registry. |
GitHub is not the best place. They have limited access rate as well. Maybe on some free CDN.
Having our public registry will be the best. |
True. If we add GH downloads pass a certain point, it will probably fail even with GH Token. But until we reach that point, it should be ok?
Could be ok but harder to manage access rights for everyone who might need to update the extensions there. |
ok, true, we pass GH token for rigrep everywhere, so probably everybody do the same already |
This patch downloads the Java debug adapter from the component's GH releases and node-debug / node-debug2 from our fork of these components, since the .vsix files are not available from upstream repos releases. Fixes #6111 Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
Fixes #6111 Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
Fixes #6111 Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
cf. #6110 (comment)
builds are broken because debug adapter cannot be fetched.
@theia/java-debug
and@theia/debug-nodejs
are affected.one option is to get rid of them at all and use the vscode extension instead.
The text was updated successfully, but these errors were encountered: