[debug] Download vscode debug extensions from elsewhere #6120
Conversation
This patch downloads the Java debug adapter from the component's GH releases and node-debug / node-debug2 from our fork of these components, since the .vsix files are not available from upstream repos releases. Fixes #6111 Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
|
@marechal-p @vince-fugnitto Could you please test that debug still works for Java and Node? |
|
@marcdumais-work fetching release artifacts from GitHub isn't considered as API call. you're redirected to some cloud storage hosted e.g. S3. also every API call's response will contain a the current rate count in headers. |
|
Oh, just noticed that #6113 is competing with this🥇 Could we agree on one way how to proceed? |
I believe this would be the better approach since it is less radical, and will not break clients unexpectedly. Removing the extensions entirely would be the last possible solution in my opinion. |
marcdumais-work
added
debug
|
@marcdumais-work We should change download debug adapters scripts that it picks up GITHUB_TOKEN from process.env and pass it as a HEADER if URL points to github.com, like here: https://github.com/microsoft/vscode-ripgrep/blob/a465bbe5eef4fa1781e0091ad906aef7fa8a7a91/lib/download.js#L105 |
|
@akosyakov, but this is only needed for API requests. |
|
@AlexTugarev ok, though that GitHub has rate limits on any request |
This patch is a minimal fix for #6111, presented as a less extreme alternative to PR #6113. Instead of removing the
@theia/debug-nodejsand@theia/java-debugtheia extensions without advance warning to our adopters that may be using them, it instead fetches the underlying debug adapters from alternate sources.It downloads the Java debug adapter from the component's GH releases and node-debug / node-debug2 from our fork of these components, since the .vsix files are not available from upstream repos releases.
The longer-term solution is, as was recently briefly discussed, to have our own public registry for extensions.
Note: The alternate sources are 3 GH repo releases. This is not ideal either since it could exacerbate the "GH API rate limit" issues we have had. However the size of all 3 extensions together is a relatively modest ~4MB, so I think that with a GH token set, it should not cause issues in our CI.
Note2: untested at the time of this PR creation, other than looking at the download folders and confirming that the content appears ok at a glance.
cc: @svenefftinge @akosyakov @AlexTugarev @kittaakos