Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode][webview] allow-forms in webviews #6694

Closed
svenefftinge opened this issue Dec 5, 2019 · 0 comments · Fixed by #6695
Closed

[vscode][webview] allow-forms in webviews #6694

svenefftinge opened this issue Dec 5, 2019 · 0 comments · Fixed by #6695
Assignees
@svenefftinge
Labels
bug bugs found in the application webviews issues related to webviews

Comments

@svenefftinge
Copy link
Contributor

Some extensions use forms to capture user input, so we need to add allow-forms to the webview iframe.
@svenefftinge svenefftinge self-assigned this Dec 5, 2019
svenefftinge added a commit that referenced this issue Dec 5, 2019
@svenefftinge
[vscode] add allow-forms
50680ae 
Fixes #6694

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
@svenefftinge svenefftinge mentioned this issue Dec 5, 2019
Merged
1 task
@akosyakov akosyakov added bug bugs found in the application webviews issues related to webviews labels Dec 5, 2019
svenefftinge added a commit that referenced this issue Dec 5, 2019
@svenefftinge
[vscode] add allow-forms
9983b6b 
Fixes #6694

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@svenefftinge @akosyakov
[vscode] add allow-forms
ab506d0 
Fixes eclipse-theia#6694

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svenefftinge svenefftinge

Labels
bug bugs found in the application webviews issues related to webviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[vscode] add allow-forms eclipse-theia/theia
2 participants
@svenefftinge @akosyakov