Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] add allow-forms #6695

Merged
merged 1 commit into from
Dec 5, 2019
Merged

[vscode] add allow-forms #6695

merged 1 commit into from
Dec 5, 2019

Conversation

svenefftinge
Copy link
Contributor

@svenefftinge svenefftinge commented Dec 5, 2019 •
edited
Loading

What it does

It adds allow-forms to webview iframe

Fixes #6694

How to test

try SQLTOOLS extension.

Review checklist

Reminder for reviewers

@svenefftinge
[vscode] add allow-forms
50680ae 
Fixes #6694

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
@akosyakov akosyakov added the webviews issues related to webviews label Dec 5, 2019
akosyakov
akosyakov approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested that SQL tools extension can submit forms now 👍

@svenefftinge svenefftinge merged commit 9983b6b into master Dec 5, 2019
@svenefftinge svenefftinge deleted the svenefftinge/vscode-webview-allow-6694 branch December 5, 2019 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov approved these changes

Assignees
No one assigned
Labels
webviews issues related to webviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[vscode][webview] allow-forms in webviews
2 participants
@svenefftinge @akosyakov