-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] fix typos present in '@theia/core' #6899
Comments
What is the protocol for updating CHANGELOG.md? I read through the code guidelines and didn't find anything about it. Should entries be alphabetical and include a reference to the issue? |
In general changelog updates are done for a given release where items are sorted alphabetically and a reference to the corresponding pull request is added. In any case, before a release the changelog is revisited to format the document + add any missing entries. |
I'm having trouble figuring out merging/branches so I'm going to look into that and re-create the changes properly. Sorry! |
- CHANGELOG now properly references pull request Signed-off-by: Justin Ang <justinang13@gmail.com>
- CHANGELOG now properly references pull request Signed-off-by: Justin Ang <justinang13@gmail.com>
Description
The following typos were discovered in
@theia/core
and should be properly fixed:offlline
>offline
theia/packages/core/src/browser/common-frontend-contribution.ts
Line 1567 in 8dcd431
theia/packages/core/src/browser/common-frontend-contribution.ts
Line 1575 in 8dcd431
theia/packages/core/src/browser/common-frontend-contribution.ts
Line 1583 in 8dcd431
theia/packages/core/src/browser/common-frontend-contribution.ts
Line 1591 in 8dcd431
retrive
>retrieve
theia/packages/core/src/browser/external-uri-service.ts
Line 31 in 8dcd431
Comosition
>Composition
(this is a breaking change and should properly documented in theCHANGELOG
)theia/packages/core/src/browser/frontend-application.ts
Lines 169 to 176 in 8dcd431
expexted
>expected
theia/packages/core/src/browser/keyboard/browser-keyboard-layout-provider.ts
Line 391 in 8dcd431
seprator
>separator
theia/packages/core/src/browser/keyboard/keys.spec.ts
Line 237 in 8dcd431
overriden
>overridden
theia/packages/core/src/browser/preferences/preference-contribution.ts
Lines 282 to 290 in 8dcd431
unversiouned
>unversioned
theia/packages/core/src/browser/shell/application-shell.ts
Line 50 in 8dcd431
renderes
>renderers
theia/packages/core/src/browser/shell/tab-bars.ts
Line 76 in 8dcd431
The text was updated successfully, but these errors were encountered: