Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix typos present in '@theia/core' #6899

Closed
vince-fugnitto opened this issue Jan 16, 2020 · 3 comments
Closed

[core] fix typos present in '@theia/core' #6899

vince-fugnitto opened this issue Jan 16, 2020 · 3 comments
Labels
documentation issues related to documentation good first issue good first issues for new contributors help wanted issues meant to be picked up, require help quality issues related to code and application quality

Comments

@vince-fugnitto
Copy link
Member

Description

The following typos were discovered in @theia/core and should be properly fixed:

offlline > offline

}, description: 'Background of hovered statusbar item in case the theia server is offlline.'

}, description: 'Background of hovered statusbar item in case the theia server is offlline.'

}, description: 'Background of hovered statusbar item in case the theia server is offlline.'

}, description: 'Background of active statusbar item in case the theia server is offlline.'


retrive > retrieve

* Use `parseLocalhost` to retrive localhost address and port information.


Comosition > Composition (this is a breaking change and should properly documented in the CHANGELOG)

protected registerComositionEventListeners(): void {
window.document.addEventListener('compositionstart', event => {
this.inComposition = true;
});
window.document.addEventListener('compositionend', event => {
this.inComposition = false;
});
}


expexted > expected

* Keyboard layout files are expexted to have the following name scheme:


seprator > separator

it('should parse minus as key and seprator', () => {


overriden > overridden

// try from overriden schema
property = this.overridePatternProperties[`[${overridden.overrideIdentifier}]`];
property = property && property[overridden.preferenceName];
if (!property) {
// try from overriden identifier
property = this.overridePatternProperties[overridden.preferenceName];
}
if (!property) {
// try from overriden value


unversiouned > unversioned

/** layout versioning is introduced, unversiouned layout are not compatible */


renderes > renderers

// right now it is mess: (1) client logic belong to renderer, (2) cyclic dependencies between renderes and clients

@vince-fugnitto vince-fugnitto added help wanted issues meant to be picked up, require help good first issue good first issues for new contributors quality issues related to code and application quality documentation issues related to documentation labels Jan 16, 2020
@justin8502
Copy link
Contributor

What is the protocol for updating CHANGELOG.md? I read through the code guidelines and didn't find anything about it. Should entries be alphabetical and include a reference to the issue?

@vince-fugnitto
Copy link
Member Author

What is the protocol for updating CHANGELOG.md? I read through the code guidelines and didn't find anything about it. Should entries be alphabetical and include a reference to the issue?

In general changelog updates are done for a given release where items are sorted alphabetically and a reference to the corresponding pull request is added. In any case, before a release the changelog is revisited to format the document + add any missing entries.

@justin8502
Copy link
Contributor

I'm having trouble figuring out merging/branches so I'm going to look into that and re-create the changes properly. Sorry!

vinokurig added a commit that referenced this issue Jan 29, 2020
This reverts commit e1d08d0.
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
- CHANGELOG now properly references pull request

Signed-off-by: Justin Ang <justinang13@gmail.com>
JesterOrNot pushed a commit to JesterOrNot/theia that referenced this issue Mar 12, 2020
- CHANGELOG now properly references pull request

Signed-off-by: Justin Ang <justinang13@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues related to documentation good first issue good first issues for new contributors help wanted issues meant to be picked up, require help quality issues related to code and application quality
Projects
None yet
Development

No branches or pull requests

2 participants