fix typos present in '@theia/core'

[justin8502]

Issue: #6899

What it does

• fixes various typos throughout the codebase.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

Thank you for taking care of the issue! 👍
Please be sure to address the minor comment, and please squash your commits into one.

Also for future reference, you can put Fixes: #6899 or other keywords in your commit message so the corresponding issue is tracked and closed on merge.

[vince-fugnitto]

Thank you for the changes, I look forward to many more contributions from you in the future!

[vince-fugnitto]

@JustinAng1 when you get a chance, do you mind fixing the conflicts of the pull-request so it can be merged?

[justin8502]

Sure, here's what I plan to do:

1. Pull from upstream repository
2. Merge + keep both changes to CHANGELOG
3. Push to master

Please let me know if there's any issues to this approach.

[vince-fugnitto]

Please let me know if there's any issues to this approach.

Since you are working off a fork, my approach would be to:

1. sync your fork against the upstream (this repo's) master:
   • https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/syncing-a-fork
2. rebase your changes against the master
3. fix the conflicts
4. amend your pull-request
5. force push your changes

[vince-fugnitto]

Please note that we cannot merge the pull-request until the conflicts have been resolved, and commits are squashed (single commit).

[justin8502]

Sorry, I'm a little confused. I merged the fork using github's tool, but now there's two commits. Should I try and resolve this using rebase (Something like git rebase HEAD~2)? Or should I attempt to roll back the repository to my last commit then merge it manually.

[vince-fugnitto]

Sorry, I'm a little confused. I merged the fork using github's tool, but now there's two commits. Should I try and resolve this using rebase (Something like git rebase HEAD~2)? Or should I attempt to roll back the repository to my last commit then merge it manually.

You can do however you feel most comfortable with :)
The only thing to make sure is that commits are squashed (unless there are multiple commits for a specific reason) and that there are no merge conflicts before we are able to successfully merge.