Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tree-view] hiding a tree view is re-opened on reload #7037

Closed
vince-fugnitto opened this issue Jan 31, 2020 · 5 comments · Fixed by #9539
Closed

[tree-view] hiding a tree view is re-opened on reload #7037

vince-fugnitto opened this issue Jan 31, 2020 · 5 comments · Fixed by #9539
Labels
bug bugs found in the application 🤔 needs more info issues that require more info from the author vscode issues related to VSCode compatibility

Comments

@vince-fugnitto
Copy link
Member

Description

There is currently a bug with hiding tree-views (ex: npm scripts) where it is re-opened on reload despite a user hiding it.

Steps to Reproduce

  1. start the application using theia as a workspace
  2. verify that the tree-view 'npm scripts' is opened
  3. right click 'npm scripts' header and un-select it or 'hide'
  4. the tree-view should be properly hidden
  5. reload the frontent (refresh the browser)
  6. notice how the 'npm scripts' tree-view is re-opened

a
@vince-fugnitto vince-fugnitto added bug bugs found in the application vscode issues related to VSCode compatibility labels Jan 31, 2020
@vince-fugnitto
Copy link
Member Author

Corresponding related issue in vscode: microsoft/vscode#35462

@vince-fugnitto
Copy link
Member Author

@akosyakov I looked at the pull-request #5855 and while explicitly hiding a view should work, it does not work in this case anymore.

@akosyakov akosyakov added the 🤔 needs more info issues that require more info from the author label Jan 31, 2020
@akosyakov
Copy link
Member

akosyakov commented Jan 31, 2020 •
edited
Loading

I will need to debug it. If it is a regression then we should add a new api test for it to catch in the future. I have not thought yet how to test page reloads and reconnections.

@vince-fugnitto vince-fugnitto mentioned this issue Apr 1, 2020
Closed
@kittaakos kittaakos mentioned this issue May 26, 2020
Merged
1 task
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 20, 2020
[Tree-view] Hide tree-view on reload
6d3053b 
Fixes: eclipse-theia#7037

Respects hide and collapse for tree-views such as `NPM Scripts` on
reload.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 21, 2020
[Tree-view] Hide tree-view on reload
f36af2d 
Fixes: eclipse-theia#7037

Respects hide and collapse for tree-views such as `NPM Scripts` on
reload.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 21, 2020
[Tree-view] Hide tree-view on reload
48bed86 
Fixes: eclipse-theia#7037

Respects hide and collapse for tree-views such as `NPM Scripts` on
reload.

Co-authored-by: Anas Shahid <muhammad.shahid@ericsson.com>
Co-authored-by: vince-fugnitto <vincent.fugnitto@ericsson.com>

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
@Anasshahidd21 Anasshahidd21 mentioned this issue Jul 21, 2020
Closed
1 task
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 21, 2020
[Tree-view] Hide tree-view on reload
2c75d47 
Fixes: eclipse-theia#7037

Respects hide and collapse for tree-views such as `NPM Scripts` on
reload.

Co-authored-by: Anas Shahid <muhammad.shahid@ericsson.com>
Co-authored-by: vince-fugnitto <vincent.fugnitto@ericsson.com>

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 21, 2020
[Tree-view] Hide tree-view on reload
a8f5c55 
Fixes: eclipse-theia#7037

Respects hide and collapse for tree-views such as `NPM Scripts` on
reload.

Co-authored-by: Anas Shahid <muhammad.shahid@ericsson.com>
Co-authored-by: vince-fugnitto <vincent.fugnitto@ericsson.com>

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 28, 2020
[Tree-view] Hide tree-view on reload
d478a8f 
Fixes: eclipse-theia#7037

Respects hide and collapse for tree-views such as `NPM Scripts` on
reload.

Co-authored-by: Anas Shahid <muhammad.shahid@ericsson.com>
Co-authored-by: vince-fugnitto <vincent.fugnitto@ericsson.com>

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 31, 2020
[Tree-view] Hide tree-view on reload
0b5bcd2 
Fixes: eclipse-theia#7037

Respects hide and collapse for tree-views such as `NPM Scripts` on
reload.

Co-authored-by: Anas Shahid <muhammad.shahid@ericsson.com>
Co-authored-by: vince-fugnitto <vincent.fugnitto@ericsson.com>

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Aug 17, 2020
[Tree-view] Hide tree-view on reload
fcc27ce 
Fixes: eclipse-theia#7037

Respects hide and collapse for tree-views such as `NPM Scripts` on
reload.

Co-authored-by: Anas Shahid <muhammad.shahid@ericsson.com>
Co-authored-by: vince-fugnitto <vincent.fugnitto@ericsson.com>

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
@vince-fugnitto
Copy link
Member Author

I can no longer reproduce the issue, likely thanks to #9156.

@vince-fugnitto
Copy link
Member Author

I believe this issue has not been resolved (it was recently reproduced).

@alvsan09 alvsan09 mentioned this issue Jun 1, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application 🤔 needs more info issues that require more info from the author vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
2 participants
@akosyakov @vince-fugnitto