Fixed collapsed state when restoring view container parts #7893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #7037? |
spoenemann
commented
May 26, 2020
| @@ -403,10 +403,8 @@ export class ViewContainer extends BaseWidget implements StatefulWidget, Applica | |||
| const part = parts[index]; | |||
| const partState = partStates.find(s => part.partId === s.partId); | |||
| if (partState) { | |||
| part.setHidden(partState.hidden); | |||
There was a problem hiding this comment.
setHidden sets collapsed = false if the part is visible (not hidden).
No, that must be caused by something else. The npm scripts part seems to be restored asynchronously. |
spoenemann
commented
May 26, 2020
| * The view container restores the visibility, order and relative sizes of contained | ||
| * widgets, but _not_ the widgets themselves. In case the set of widgets is not fixed, | ||
| * it should be restored in the specific subclass or in the widget holding the view container. | ||
| */ |
There was a problem hiding this comment.
This comment is outdated. @akosyakov implemented restoring of contained widgets in 9320510
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes restoration of view container parts state, specifically the
collapsedstate.How to test
Open a view container (e.g. Debug or Extensions), collapse some parts and reload the page.
Before this change: all visible parts are expanded.
After this change: parts are kept collapsed or expanded as before.
Review checklist
Reminder for reviewers