Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasks: 'run last task' does not work for detected tasks #7398

Closed
vince-fugnitto opened this issue Mar 23, 2020 · 0 comments · Fixed by #7553
Closed

tasks: 'run last task' does not work for detected tasks #7398

vince-fugnitto opened this issue Mar 23, 2020 · 0 comments · Fixed by #7553
Assignees
Labels
bug bugs found in the application tasks issues related to the task system

Comments

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Mar 23, 2020

Description

The command run last task does not work properly for detected tasks.
If a detected task is run and completes, attempting to 'run last task' does not work, nor does it give any feedback to end-users.

Steps to Reproduce

  1. start the application using packages/task/test-resources as a workspace
  2. create the file package.json
  3. add the following in the package.json (detected task):
    {
        "scripts": {
             "test": "echo start && sleep 10 && echo end"
        }
    }
  4. run the task (npm: test), and wait for it to complete
  5. attempt to run the command 'run last task' (nothing should happen)
  6. run another task (ex: 'test task'), and wait for it to complete
  7. the command 'run last task' works properly for this task

Additional Info

I also attempted to 'configure' the detected task and it still did not work properly when attempting to 'run last task'.

@vince-fugnitto vince-fugnitto changed the title tasks: tasks: 'run last task' does not work for detected tasks Mar 23, 2020
@akosyakov akosyakov added bug bugs found in the application tasks issues related to the task system labels Mar 23, 2020
@elaihau elaihau self-assigned this Apr 12, 2020
elaihau added a commit that referenced this issue Apr 12, 2020
- This change fixes the bug where the command "Run last task" does not work properly for detected tasks. With the new property "scope" added to the "last run task", `ProvidedTaskConfigurations.getTask()` is able to find the detected task that was run most recently.

- fixes #7398

Signed-off-by: Liang Huang <lhuang4@ualberta.ca>
elaihau added a commit that referenced this issue Apr 13, 2020
- This change fixes the bug where the command "Run last task" does not work properly for detected tasks. With the new property "scope" added to the "last run task", `ProvidedTaskConfigurations.getTask()` is able to find the detected task that was run most recently.

- fixes #7398

Signed-off-by: Liang Huang <lhuang4@ualberta.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application tasks issues related to the task system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants