save scope as part of the TaskService.lastTask
#7553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This change fixes the bug where the command "Run last task" does not work properly for detected tasks. With the new property "scope" added to the "last run task", `ProvidedTaskConfigurations.getTask()` is able to find the detected task that was run most recently. - fixes #7398 Signed-off-by: Liang Huang <lhuang4@ualberta.ca>
vince-fugnitto
approved these changes
Apr 13, 2020
|
Thank you for the review @vince-fugnitto ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the bug where the command "Run last task" does not work properly for detected tasks. With the new property "scope" added to the "last run task",
ProvidedTaskConfigurations.getTask()is able to find the detected task that was run most recently.fixes tasks: 'run last task' does not work for detected tasks #7398
Signed-off-by: Liang Huang lhuang4@ualberta.ca
How to test
package.json:Terminal -> Run Last Taskfrom the top menu bar, and check if it starts the right task.Review checklist