Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

markers: better sync between editor and problems-view #7436

Closed
vince-fugnitto opened this issue Mar 27, 2020 · 4 comments · Fixed by #8172
Closed

markers: better sync between editor and problems-view #7436

vince-fugnitto opened this issue Mar 27, 2020 · 4 comments · Fixed by #8172
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help markers issues related to problem markers

Comments

@vince-fugnitto
Copy link
Member

Description

At the moment, there is no sync between the active editor and the problems-view meaning that problems are not revealed in the tree based on the editor.

There are two main use-cases not handled:

  • switching/opening an editor does not reveal it's markers in the problems-view
  • if markers are collapsed in the problems-view, the active editor's node is not expanded

Both use-cases are successfully handled by vscode:

Expanding

expand
@vince-fugnitto vince-fugnitto added enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help markers issues related to problem markers labels Mar 27, 2020
@Anasshahidd21
Copy link
Contributor

In order to sync the markers with the activeEditor. We will need to couple the Editor with Markers, imo. Is there any other way/suggestion for fixing this issue without coupling the two?

@akosyakov
Copy link
Member

You can rely on NavigatableWidget. EditorWidget implements it.

@akosyakov
Copy link
Member

@vince-fugnitto Are there any preferences to control it?

@vince-fugnitto
Copy link
Member Author

@vince-fugnitto Are there any preferences to control it?

Yes, it looks like the following preference in vscode controls it (problems.autoReveal):

Screen Shot 2020-04-09 at 10 54 16 AM

Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 14, 2020
[markers] Sync problem markers with active editor
223c2ac 
Fixes: eclipse-theia#7436

Reveals and expands the markers for the active editor.
Added a preference `problems.autoReveal` to control this behavior.
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 14, 2020
[markers] Sync problem markers with active editor
cf1117f 
Fixes: eclipse-theia#7436

Reveals and expands the markers for the active editor.
Added a preference `problems.autoReveal` to control this behavior.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
@Anasshahidd21 Anasshahidd21 mentioned this issue Jul 14, 2020
Merged
1 task
vince-fugnitto pushed a commit to Anasshahidd21/theia that referenced this issue Jul 15, 2020
@vince-fugnitto
[markers] Sync problem markers with active editor
733063d 
Fixes: eclipse-theia#7436

Reveals and expands the markers for the active editor.
Added a preference `problems.autoReveal` to control this behavior.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 15, 2020
[markers] Sync problem markers with active editor
67be0b7 
Fixes: eclipse-theia#7436

Reveals and expands the markers for the active editor.
Added a preference `problems.autoReveal` to control this behavior.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 15, 2020
[markers] Sync problem markers with active editor
ce7a0d8 
Fixes: eclipse-theia#7436

Reveals and expands the markers for the active editor.
Added a preference `problems.autoReveal` to control this behavior.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 15, 2020
[markers] Sync problem markers with active editor
0b58e8f 
Fixes: eclipse-theia#7436

Reveals and expands the markers for the active editor.
Added a preference `problems.autoReveal` to control this behavior.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 15, 2020
[markers] Sync problem markers with active editor
8799906 
Fixes: eclipse-theia#7436

Reveals and expands the markers for the active editor.
Added a preference `problems.autoReveal` to control this behavior.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
vince-fugnitto pushed a commit to Anasshahidd21/theia that referenced this issue Jul 15, 2020
@vince-fugnitto
[markers] Sync problem markers with active editor
3185325 
Fixes: eclipse-theia#7436

Reveals and expands the markers for the active editor.
Added a preference `problems.autoReveal` to control this behavior.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 15, 2020
[markers] Sync problem markers with active editor
766839b 
Fixes: eclipse-theia#7436

Reveals and expands the markers for the active editor.
Added a preference `problems.autoReveal` to control this behavior.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 21, 2020
[markers] Sync problem markers with active editor
5c63557 
Fixes: eclipse-theia#7436

Reveals and expands the markers for the active editor.
Added a preference `problems.autoReveal` to control this behavior.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 21, 2020
[markers] Sync problem markers with active editor
350c9b2 
Fixes: eclipse-theia#7436

Reveals and expands the markers for the active editor.
Added a preference `problems.autoReveal` to control this behavior.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
vince-fugnitto pushed a commit that referenced this issue Jul 23, 2020
@vince-fugnitto
[markers] Sync problem markers with active editor
fd23988 
Fixes: #7436

Reveals and expands the markers for the active editor.
Added a preference `problems.autoReveal` to control this behavior.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
minyoungyang pushed a commit to minyoungyang/theia that referenced this issue Aug 4, 2020
@minyoungyang
[markers] Sync problem markers with active editor
0f4fd59 
Fixes: eclipse-theia#7436

Reveals and expands the markers for the active editor.
Added a preference `problems.autoReveal` to control this behavior.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help markers issues related to problem markers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[markers] Sync problem markers with active editor Anasshahidd21/theia
3 participants
@akosyakov @vince-fugnitto @Anasshahidd21