[markers] Sync problem markers with active editor

[Anasshahidd21]

What it does

Fixes: #7436

Reveals and expands the markers for the active editor.
Added a preference problems.autoReveal to control this behavior.

Signed-off-by: Muhammad Anas Shahid muhammad.shahid@ericsson.com

How to test

1. Open multiple editors with Problem markers ( one can create multiple .json files with dummy text)
2. Change the active editor and check to see if, in the problems view, the active editor markers are selected.
3. Collapse all markers, then change the active editor, check to see if the markers for active editor are expanded.
4. From the preferences, goto problems.autoReveal uncheck it, and check to see if while changing the active editors the markers are expanded or selected. (in ideal case, they should not be expanded or selected)

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

I verified the changes and they work well 👍

problems.autoReveal = true:

• the marker info nodes are correctly expanded and revealed (even when the tree is collapsed)

problems.autoReveal = false:

• the behavior is like today, there is no reveal present when switching active editors

The only drawback is that preview editors are not revealed initially (likely since they are not active) until the editor is focused. I'm fine with this approach but just wanted to mention it works correctly in vscode.

[Anasshahidd21]

Thank you for your review @vince-fugnitto.

The only drawback is that preview editors are not revealed initially (likely since they are not active) until the editor is focused. I'm fine with this approach but just wanted to mention it works correctly in vscode.

I have updated the code to make sure the behavior is consistent with editor-preview as well.

[akosyakov]

I wonder why don't we follow on initial opening, but only a change?

[kaiyue0329]

The changes work well. The correct problem markers are selected and expanded (if they are previously collapsed) when we change active editor. I also verify that unchecking problems.autoReveal preference works correctly.

[vince-fugnitto]

The changes work well 👍

I verified the behavior when:

• switching the preference applies the following logic correctly
• problemsAutoReveal: on:
  • The problem marker nodes are correctly expanded and selected when their corresponding editor or editor-preview are opened. The behavior also works well for new markers, and when the problems-view is collapsed.
• problemsAutoReveal: off:
  • The problem marker nodes behave like master - they are not expanded and selected when their corresponding editors are opened. End-users must explicitly expand the nodes in the tree.

[akosyakov]

code-wise looks good