Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Typescript suggestions for Typescript files when using builtin version 1.44.2 #7810

Closed
lmcbout opened this issue May 13, 2020 · 0 comments · Fixed by #7820
Closed

No Typescript suggestions for Typescript files when using builtin version 1.44.2 #7810

lmcbout opened this issue May 13, 2020 · 0 comments · Fixed by #7820
Assignees
@akosyakov
Labels
bug bugs found in the application typescript issues related to the typescript language

Comments

@lmcbout
Copy link
Contributor

lmcbout commented May 13, 2020 •
edited by vince-fugnitto
Loading

Bug Description:

With the latest builtin version 1.44.2, I see the following error on the console.log when working with typescript file:

Invalid Completion Item -> must be single line and on the same line
root ERROR [hosted-plugin: 4343] Invalid Completion Item -> must be single line and on the same line

Steps to Reproduce:

  1. Open a type script file
  2. Type "this."
    --> The auto-suggestion should show suggestions other than the data already in the file, no typescript suggestions and an error is reported on the console

Additional Information

  • Operating System: Ubuntu 18.04
  • Theia Version: Latest commit 09d90c4
  • Builtin version: 1.44.2
@lmcbout lmcbout changed the title Noi Typescript suggestions fior Typescript files when using builtin version 1.44.2 No Typescript suggestions for Typescript files when using builtin version 1.44.2 May 13, 2020
@akosyakov akosyakov added bug bugs found in the application help wanted issues meant to be picked up, require help typescript issues related to the typescript language labels May 13, 2020
@akosyakov akosyakov self-assigned this May 14, 2020
@akosyakov akosyakov removed the help wanted issues meant to be picked up, require help label May 14, 2020
akosyakov added a commit that referenced this issue May 14, 2020
@akosyakov
fix #7810: support new CompletionItem.range shape
8afa0b6 
Also don't send:
- duplicate ranges on provide completions
- entire completion back and forth on resolve completion

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue May 14, 2020
Merged
1 task
akosyakov added a commit that referenced this issue May 14, 2020
@akosyakov
fix #7810: support new CompletionItem.range shape
bf4e09b 
Also don't send:
- duplicate ranges on provide completions
- entire completion back and forth on resolve completion

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue May 15, 2020
@akosyakov
fix #7810: support new CompletionItem.range shape
96e3c72 
Also don't send:
- duplicate ranges on provide completions
- entire completion back and forth on resolve completion

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug bugs found in the application typescript issues related to the typescript language
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[vscode] support new CompletionItem.range shape eclipse-theia/theia
2 participants
@lmcbout @akosyakov