Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[preferences][keybinding] Duplicate keybinding for opening the preferences widget #8202

Closed
kittaakos opened this issue Jul 20, 2020 · 1 comment · Fixed by #8256
Closed
Labels
bug bugs found in the application good first issue good first issues for new contributors keybindings issues related to keybindings

Comments

@kittaakos
Copy link
Contributor

Bug Description:

On macOS, there should be one keybinding for opening the preferences widget: Cmd+,. Currently, both Cmd and Ctrl work on macOS:

if (isOSX && !isFirefox) {
keybindings.registerKeybinding({
command: CommonCommands.OPEN_PREFERENCES.id,
keybinding: 'cmd+,'
});
}
keybindings.registerKeybinding({
command: CommonCommands.OPEN_PREFERENCES.id,
keybinding: 'ctrl+,',
});

Steps to Reproduce:

Additional Information

  • Operating System:
  • Theia Version:
@kittaakos kittaakos added bug bugs found in the application keybindings issues related to keybindings good first issue good first issues for new contributors labels Jul 20, 2020
@kittaakos
Copy link
Contributor Author

Same for Delete:

registry.registerKeybinding({
command: WorkspaceCommands.FILE_DELETE.id,
keybinding: 'del',
context: NavigatorKeybindingContexts.navigatorActive
});
if (isOSX) {
registry.registerKeybinding({
command: WorkspaceCommands.FILE_DELETE.id,
keybinding: 'cmd+backspace',
context: NavigatorKeybindingContexts.navigatorActive
});
}

minyoungyang added a commit to minyoungyang/theia that referenced this issue Jul 28, 2020
…and deleting file on navigator

Fixes: eclipse-theia#8202

Made keybindings not duplicated for opening the preferences widget and deleting file on navigator on MacOS

Signed-off-by: Min-young Yang <didalsdud@gmail.com>
minyoungyang added a commit to minyoungyang/theia that referenced this issue Jul 28, 2020
…and deleting file on navigator

Fixes: eclipse-theia#8202

Made keybindings not duplicated for opening the preferences widget and deleting file on navigator on MacOS

Signed-off-by: Min-young Yang <didalsdud@gmail.com>
minyoungyang added a commit to minyoungyang/theia that referenced this issue Jul 29, 2020
…and deleting file on navigator

Fixes: eclipse-theia#8202

Made keybindings not duplicated for opening the preferences widget and deleting file on navigator on MacOS

Signed-off-by: Min-young Yang <didalsdud@gmail.com>
akosyakov pushed a commit that referenced this issue Aug 3, 2020
…and deleting file on navigator

Fixes: #8202

Made keybindings not duplicated for opening the preferences widget and deleting file on navigator on MacOS

Signed-off-by: Min-young Yang <didalsdud@gmail.com>
minyoungyang added a commit to minyoungyang/theia that referenced this issue Aug 4, 2020
…and deleting file on navigator

Fixes: eclipse-theia#8202

Made keybindings not duplicated for opening the preferences widget and deleting file on navigator on MacOS

Signed-off-by: Min-young Yang <didalsdud@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application good first issue good first issues for new contributors keybindings issues related to keybindings
Projects
None yet
1 participant