-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[preferences][keybinding] Duplicate keybinding for opening the preferences widget #8202
Labels
bug
bugs found in the application
good first issue
good first issues for new contributors
keybindings
issues related to keybindings
Comments
kittaakos
added
bug
bugs found in the application
keybindings
issues related to keybindings
good first issue
good first issues for new contributors
labels
Jul 20, 2020
Same for theia/packages/navigator/src/browser/navigator-contribution.ts Lines 443 to 454 in 4c63f08
|
minyoungyang
added a commit
to minyoungyang/theia
that referenced
this issue
Jul 28, 2020
…and deleting file on navigator Fixes: eclipse-theia#8202 Made keybindings not duplicated for opening the preferences widget and deleting file on navigator on MacOS Signed-off-by: Min-young Yang <didalsdud@gmail.com>
minyoungyang
added a commit
to minyoungyang/theia
that referenced
this issue
Jul 28, 2020
…and deleting file on navigator Fixes: eclipse-theia#8202 Made keybindings not duplicated for opening the preferences widget and deleting file on navigator on MacOS Signed-off-by: Min-young Yang <didalsdud@gmail.com>
1 task
minyoungyang
added a commit
to minyoungyang/theia
that referenced
this issue
Jul 29, 2020
…and deleting file on navigator Fixes: eclipse-theia#8202 Made keybindings not duplicated for opening the preferences widget and deleting file on navigator on MacOS Signed-off-by: Min-young Yang <didalsdud@gmail.com>
1 task
akosyakov
pushed a commit
that referenced
this issue
Aug 3, 2020
…and deleting file on navigator Fixes: #8202 Made keybindings not duplicated for opening the preferences widget and deleting file on navigator on MacOS Signed-off-by: Min-young Yang <didalsdud@gmail.com>
minyoungyang
added a commit
to minyoungyang/theia
that referenced
this issue
Aug 4, 2020
…and deleting file on navigator Fixes: eclipse-theia#8202 Made keybindings not duplicated for opening the preferences widget and deleting file on navigator on MacOS Signed-off-by: Min-young Yang <didalsdud@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
bugs found in the application
good first issue
good first issues for new contributors
keybindings
issues related to keybindings
Bug Description:
On macOS, there should be one keybinding for opening the preferences widget:
Cmd+,
. Currently, bothCmd
andCtrl
work on macOS:theia/packages/preferences/src/browser/preference-contribution.ts
Lines 133 to 143 in ac06ac9
Steps to Reproduce:
Additional Information
The text was updated successfully, but these errors were encountered: