Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keybinding] Duplicate keybinding for opening the preferences widget and deleting file on navigator #8256

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

minyoungyang
Copy link
Contributor

Fixes #8202

What it does

  • Made keybindings not duplicated for opening the preferences widget and deleting file on navigator on MacOS

How to test

  • Open preference widget by pressing 'ctrl+,' on Windows
  • Delete files on navigator by pressing 'del' on Windows

Review checklist

Reminder for reviewers

Signed-off-by: Min-young Yang didalsdud@gmail.com

…and deleting file on navigator

Fixes: eclipse-theia#8202

Made keybindings not duplicated for opening the preferences widget and deleting file on navigator on MacOS

Signed-off-by: Min-young Yang <didalsdud@gmail.com>
@minyoungyang
Copy link
Contributor Author

@vince-fugnitto I create new pull request, because I had a problem with git. Review again please. Thank you.

@akosyakov akosyakov added the keybindings issues related to keybindings label Jul 29, 2020
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@akosyakov akosyakov merged commit f803fc0 into eclipse-theia:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keybindings issues related to keybindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[preferences][keybinding] Duplicate keybinding for opening the preferences widget
3 participants