Latest Java test runner extension fails in displaying tree icons

[sunix]

Bug Description:

Hello, I tried the latest Java test runner extension and there is a regression in Theia in the tree:

• The green passed icon is not displayed
• The red failed icon is not red

Maybe caused by microsoft/vscode-java-test#1099
Related to #8267

CAN NOT reproduce with Java test runner 0.24.2
CAN reproduce with Java test runner 0.27.0

Steps to Reproduce:

With Che:

1. Start any Java workspace from Che.
2. Edit the devfile and add the custom registry url for the quarkus or java plugin for instance:

    - id: redhat/quarkus-java11/latest
      type: chePlugin
      registryUrl: 'https://sunix-che-plugin-registry-java-test-runner-0-27-0.surge.sh/v3'

3. Start the workspace and run the test

With Gitpod:

1. Start the petclinic sample
2. install the Java test runner extension
3. Run the test

Same one in vscode:

[vince-fugnitto]

@sunix I believe it is the same issue as #8905 (comment), they are new codicons which are supported in the newer version of monaco. An update of monaco is most likely required: #8969.

Update: I verified that the pass icon is not in our codicons file from @theia/monaco-editor-core.

[sunix]

@vince-fugnitto yep maybe let's see how the new monaco updates goes

[vince-fugnitto]

@vince-fugnitto yep maybe let's see how the new monaco updates goes

I was hoping we could directly consume vscode-codicons as an icon font, rather than have to rely on a monaco upgrade (which requires significantly more effort): #6115 (comment). Perhaps it is something we can consider for the future (https://github.com/microsoft/vscode-codicons) and will allow us to update icons more easily.

[TomHermanSAP]

Hi @vince-fugnitto @sunix,
Several points:

1. Is there a planned schedule regarding updating monaco and vscode-icons? (when and how long would it take)
   Here are some related issues I found:
   Update VSCode Icons #6115: Update VSCode Icons (Open since Sep. 2019)
   Icons are missing in Java Projects Panel #8905: Missing "Export" icon in "Project Manager for Java" extension

2. Is there a way I can help with the process of updating them?

Thank you!

[vince-fugnitto]

1. Is there a planned schedule regarding updating monaco and vscode-icons? (when and how long would it take)
   Here are some related issues I found:
   Update VSCode Icons #6115: Update VSCode Icons (Open since Sep. 2019)
   Icons are missing in Java Projects Panel #8905: Missing "Export" icon in "Project Manager for Java" extension

@TomHermanSAP are you looking into replacing the icons present in the application to those of codicons? If so then you can update the existing icons to codicons using the codicon syntax. Codicons are contributed through the monaco-editor dependency. For plugins there should not be anything to do to make use of the icons, only that certain icons are present in newer versions of monaco which require an update (like java).

2. Is there a way I can help with the process of updating them?

You can provide a pull-request to update icons if you like. We can essentially continue the work of #6993 but there is no need to copy icons into our sources, we have them already available.

[TomHermanSAP]

@vince-fugnitto To be honest I do not know and could not understand which and where icons from monaco and from vscode-icons are used, and I am not planning on changing any icons in any plugins / extensions.

Based on your answer, I understand that once #8969 will be merged the missing icons described in #8981 & #8905 will be seen.

Then, I will wait for #8969 to be merged.

Thank you again.

[vince-fugnitto]

The following should be fixed if someone wants to test it out 👍

[vince-fugnitto]

@sunix still an issue?